From: Mikael Magnusson <mikachu@gmail.com>
To: zsh-workers@zsh.org
Subject: PATCH: [RFC] crash with weird completer
Date: Tue, 8 Mar 2022 20:32:46 +0100 [thread overview]
Message-ID: <20220308193246.3204-1-mikachu@gmail.com> (raw)
minimal reproducer .zshrc:
zstyle ':completion:*' completer _oldlist _complete
setopt nolistambiguous
autoload compinit; compinit
compdef _foo foo;_foo() { compadd -Q -- stash@{{0,1}} }
type "foo " and press tab twice, and it should crash.
The patch prevents the crash but I have no further arguments that it's
correct. Also without 'setopt nolistambiguous' we just get an additional
{ inserted for every tab press which also doesn't seem useful (not fixed
by patch).
(Apologies if I've sent this before, looking through local commits that
could potentially be useful to send.)
---
Src/Zle/compresult.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Src/Zle/compresult.c b/Src/Zle/compresult.c
index 8b5955819a..12585e3564 100644
--- a/Src/Zle/compresult.c
+++ b/Src/Zle/compresult.c
@@ -608,7 +608,7 @@ instmatch(Cmatch m, int *scs)
r += l;
ocs = zlemetacs;
/* Re-insert the brace beginnings, if any. */
- if (brbeg) {
+ if (brbeg && m->brpl) {
int pcs = zlemetacs;
l = 0;
--
2.15.1
next reply other threads:[~2022-03-08 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 19:32 Mikael Magnusson [this message]
2022-03-10 5:47 ` Bart Schaefer
2022-03-10 12:27 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308193246.3204-1-mikachu@gmail.com \
--to=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).