From: Stephane Chazelas <email@example.com>
To: Mikael Magnusson <firstname.lastname@example.org>
Subject: Re: PATCH: <<<: Document newline behavior and fix optimization
Date: Sun, 13 Mar 2022 19:35:56 +0000 [thread overview]
Message-ID: <email@example.com> (raw)
2022-03-13 20:28:35 +0100, Mikael Magnusson:
> On 3/13/22, Stephane Chazelas <firstname.lastname@example.org> wrote:
> > 2022-03-08 19:58:32 +0100, Mikael Magnusson:
> >> The =(<<<foo) optimization forgot to add a newline, but =(cat<<<foo)
> >> always did, make the behavior consistent, and document it.
> > [...]
> > The edit-command-line contrib widget may be relying on =(<<<xxx)
> > not adding a newline character.
> The output from the editor is read with $() so I think it will cancel
> out, either way. Just tested invoking it and pressing enter a bunch of
> times, and was returned to an empty command line.
You're right sorry. I just came across the definition of that
widget and saw that =(<<<...) in it which reminded me of this
discussion. But I didn't look at it further.
If anything, your change would improved it, as at the moment, it
would likely launch a text editor on something that is not text
as it wouldn't end in a newline.
next prev parent reply other threads:[~2022-03-13 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 18:58 Mikael Magnusson
2022-03-08 19:38 ` Bart Schaefer
2022-03-08 19:42 ` Bart Schaefer
2022-03-09 11:10 ` Stephane Chazelas
2022-03-13 18:50 ` Stephane Chazelas
2022-03-13 19:28 ` Mikael Magnusson
2022-03-13 19:35 ` Stephane Chazelas [this message]
2022-03-30 7:17 ` Jun T
2022-03-30 8:02 ` Mikael Magnusson
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).