zsh-workers
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: zsh-workers@zsh.org
Cc: Peter Stephenson <p.w.stephenson@ntlworld.com>,
	Daniel Shahaf <d.s@daniel.shahaf.name>,
	Bart Schaefer <schaefer@brasslantern.com>,
	Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH 2/2] Increase default HISTSIZE to 1000
Date: Tue, 30 Aug 2022 22:18:54 -0500	[thread overview]
Message-ID: <20220831031854.27312-3-felipe.contreras@gmail.com> (raw)
In-Reply-To: <20220831031854.27312-1-felipe.contreras@gmail.com>

If the default is sensible it's not necessary for the user to change it.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 Etc/FAQ.yo                            | 13 +++++--------
 Functions/Newuser/zsh-newuser-install |  1 -
 StartupFiles/zshrc                    |  2 +-
 configure.ac                          |  2 +-
 4 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/Etc/FAQ.yo b/Etc/FAQ.yo
index dd573767e..4c058c363 100644
--- a/Etc/FAQ.yo
+++ b/Etc/FAQ.yo
@@ -1626,19 +1626,16 @@ work?)
 sect(Why is my history not being saved?)
 label(321)
 
-  In zsh, you need to set three variables to make sure your history is
+  In zsh, you need to set two variables to make sure your history is
   written out when the shell exits.  For example,
   verb(
-    HISTSIZE=200
     HISTFILE=~/.zsh_history
     SAVEHIST=$HISTSIZE
   )
-  tt($HISTSIZE) tells the shell how many lines to keep internally,
-  tt($HISTFILE) tells it where to write the history, and tt($SAVEHIST),
-  the easiest one to forget, tells it how many to write out.  The
-  simplest possibility is to set it to the same as tt($HISTSIZE) as
-  above.  There are also various options affecting history; see the
-  manual.
+  tt($HISTFILE) tells the shell where to write the history, and tt($SAVEHIST)
+  tells it how many lines to write out.  The simplest possibility is to set it
+  to the same as tt($HISTSIZE) as above.  There are also various options
+  affecting history; see the manual.
 
 sect(How do I get a variable's value to be evaluated as another variable?)
 
diff --git a/Functions/Newuser/zsh-newuser-install b/Functions/Newuser/zsh-newuser-install
index 386844a71..46b1639c5 100644
--- a/Functions/Newuser/zsh-newuser-install
+++ b/Functions/Newuser/zsh-newuser-install
@@ -790,7 +790,6 @@ ${(F)unparsed}
 
 __zni_history_config() {
   __zni_apply_defaults -p \
-    HISTSIZE 1000 "Number of lines of history kept within the shell." \
     HISTFILE $zdmsg/.histfile "File where history is saved." \
     SAVEHIST \$HISTSIZE "Number of lines of history to save to \$HISTFILE."
 
diff --git a/StartupFiles/zshrc b/StartupFiles/zshrc
index d4e1d03cc..f8a0233bf 100644
--- a/StartupFiles/zshrc
+++ b/StartupFiles/zshrc
@@ -79,7 +79,7 @@ export HELPDIR=/usr/share/zsh/$ZSH_VERSION/help  # directory for run-help functi
 unalias run-help && autoload -Uz run-help
 
 MAILCHECK=300
-HISTSIZE=200
+HISTSIZE=1000
 DIRSTACKSIZE=20
 
 # Watch for my friends
diff --git a/configure.ac b/configure.ac
index 890ef8dd2..6ca5c9189 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3213,7 +3213,7 @@ AH_TOP([/***** begin user configuration section *****/
 #define USE_SUSPENDED 1
  
 /* The default history buffer size in lines */
-#define DEFAULT_HISTSIZE 30
+#define DEFAULT_HISTSIZE 1000
 
 /* The default editor for the fc builtin */
 #define DEFAULT_FCEDIT "vi"
-- 
2.37.2.351.g9bf691b78c.dirty



  parent reply	other threads:[~2022-08-31  3:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31  3:18 [PATCH 0/2] Useful default of HISTSIZE Felipe Contreras
2022-08-31  3:18 ` [PATCH 1/2] Set SAVEHIST to $HISTSIZE by default Felipe Contreras
2022-09-02  8:59   ` Daniel Shahaf
2022-09-02  9:29     ` Felipe Contreras
2022-09-02 10:01       ` Daniel Shahaf
2022-09-02 13:25         ` Felipe Contreras
2022-09-06 20:13           ` Felipe Contreras
2022-08-31  3:18 ` Felipe Contreras [this message]
2022-09-02  9:01   ` [PATCH 2/2] Increase default HISTSIZE to 1000 Daniel Shahaf
2022-09-02  9:49     ` Felipe Contreras
2022-08-31  3:39 ` [PATCH 0/2] Useful default of HISTSIZE Lawrence Velázquez
2022-08-31  5:57   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220831031854.27312-3-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).