Re: [PATCH 2/2] Increase default HISTSIZE to 1000

[Felipe Contreras <felipe.contreras@gmail.com>]

On Fri, Sep 2, 2022 at 4:01 AM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Felipe Contreras wrote on Tue, Aug 30, 2022 at 22:18:54 -0500:

> > If the default is sensible it's not necessary for the user to change it.
> >
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > ---
> >  Etc/FAQ.yo                            | 13 +++++--------
> >  Functions/Newuser/zsh-newuser-install |  1 -
> >  StartupFiles/zshrc                    |  2 +-
> >  configure.ac                          |  2 +-
> >  4 files changed, 7 insertions(+), 11 deletions(-)
> >
> > diff --git a/Etc/FAQ.yo b/Etc/FAQ.yo
> > index dd573767e..4c058c363 100644
> > --- a/Etc/FAQ.yo
> > +++ b/Etc/FAQ.yo
> > @@ -1626,19 +1626,16 @@ work?)
> >  sect(Why is my history not being saved?)
> >  label(321)
> >
> > -  In zsh, you need to set three variables to make sure your history is
> > +  In zsh, you need to set two variables to make sure your history is
>
> If 1/2 is accepted, this sentence will be true for zsh 5.10

No, it's true for all versions of zsh.

Right now the default value of HISTSIZE is 30, therefore the text is
wrong, you don't need 3 variables, you only need 2: HISTFILE and
SAVEHIST.

In fact, I just learned APPEND_HISTORY is on by default, this means a
HISTSIZE of 30 is actually quite useful. You don't need to increase it
to make sure your history is written, you only need to increase it to
make sure you don't lose any history of your current shell instance.

Either way you don't *need* to set it, with this patch or without it.

And patch 1 certainly doesn't change the situation. All it does is
make sure SAVEHIST is the same as HISTSIZE, whether it's 1000, 200, or
30. HISTSIZE can be removed regardless of the previous patch.

-- 
Felipe Contreras