Test D03 hang under cygwin 1.7

Test D03 hang under cygwin 1.7

[Vin Shelton]

Hello -

Under the soon-to-be-released Cygwin 1.7, I downloaded the latest CVS
sources and ran a build from scratch.  I'm getting a test hang in D03:

ZTST_verbose=3 make TESTNUM=D03 check
cd Test ; make check
make[1]: Entering directory `/usr/local/build/zsh-2009-02-05/Test'
if test -n "gcc"; then \
          cd .. && DESTDIR= \
          make MODDIR=`pwd`/Test/Modules install.modules > /dev/null; \
        fi
if ZTST_testlist="`for f in /usr/local/src/zsh-2009-02-05/Test/D03*.ztst; \
           do echo $f; done`" \
         ZTST_srcdir="/usr/local/src/zsh-2009-02-05/Test" \
         ZTST_exe=../Src/zsh.exe \
         ../Src/zsh.exe +Z -f
/usr/local/src/zsh-2009-02-05/Test/runtests.zsh; then \
         stat=0; \
        else \
         stat=1; \
        fi; \
        rm -rf Modules .zcompdump; \
        exit $stat
/usr/local/src/zsh-2009-02-05/Test/D03procsubst.ztst: starting.
ZTST_getsect: read section name: prep
ZTST_getchunk: read code chunk:
  if grep '#define PATH_DEV_FD' $ZTST_testdir/../config.h > /dev/null 2>&1 ||
     grep '#define HAVE_FIFOS' $ZTST_testdir/../config.h > /dev/null 2>&1; then
    mkdir procsubst.tmp
    cd procsubst.tmp
    print 'First\tSecond\tThird\tFourth' >FILE1
    print 'Erste\tZweite\tDritte\tVierte' >FILE2
  else
    ZTST_unimplemented="process substitution is not supported"
    true
  fi
ZTST_execchunk: status 0
ZTST_getchunk: read code chunk:
  function copycat { cat "$@" }
ZTST_execchunk: status 0
ZTST_getchunk: read code chunk:

ZTST_getsect: read section name: test
ZTST_test: looking for new test
ZTST_test: examining line:
  paste <(cut -f1 FILE1) <(cut -f3 FILE2)
ZTST_getchunk: read code chunk:
  paste <(cut -f1 FILE1) <(cut -f3 FILE2)
ZTST_test: examining line:
>First  Dritte
ZTST_getredir: read redir for '>':
First   Dritte
ZTST_test: examining line:

Running test: <(...) substitution
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.3712, output: /tmp/zsh.ztst.out.3712, error:
/tmp/zsh.ztst.terr.3712
make[1]: *** [check] Interrupt
make: *** [check] Interrupt

Re: Test D03 hang under cygwin 1.7

[Peter Stephenson]

On Thu, 5 Feb 2009 23:07:24 -0500
Vin Shelton <acs@alumni.princeton.edu> wrote:
> Under the soon-to-be-released Cygwin 1.7, I downloaded the latest CVS
> sources and ran a build from scratch.  I'm getting a test hang in D03:

This is process substitution again.  This is problematic under Cygwin:
sometimes one of the two forms works, sometimes another, even though both
are notionally present and zsh is simply using documented behaviour that
works on other systems.  (The real problem, of course, is that process
handling is intrinsically horrific in Cygwin.)

I don't think we can do much more than skip the test and put a warning
about related features in the manual.  We might be able to add an option to
pick the support we use (named pipes or device files) but that's probably
only of use to the sort of people who could in any case hack the
configuration by hand.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: Test D03 hang under cygwin 1.7

[Peter Stephenson]

On Fri, 6 Feb 2009 09:56:26 +0000
Peter Stephenson <pws@csr.com> wrote:
> On Thu, 5 Feb 2009 23:07:24 -0500
> Vin Shelton <acs@alumni.princeton.edu> wrote:
> > Under the soon-to-be-released Cygwin 1.7, I downloaded the latest CVS
> > sources and ran a build from scratch.  I'm getting a test hang in D03:
> 
> This is process substitution again.  This is problematic under Cygwin:
> sometimes one of the two forms works, sometimes another, even though both
> are notionally present and zsh is simply using documented behaviour that
> works on other systems.  (The real problem, of course, is that process
> handling is intrinsically horrific in Cygwin.)
> 
> I don't think we can do much more than skip the test and put a warning
> about related features in the manual.  We might be able to add an option to
> pick the support we use (named pipes or device files) but that's probably
> only of use to the sort of people who could in any case hack the
> configuration by hand.

... in fact, could you try #define'ing PATH_DEV_FD in config.h (it's turned
off by a special test in configure) and see if that works with the new
version of Cygwin?  We can always reverse the configured default when that
comes out.

Thanks.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: Test D03 hang under cygwin 1.7

[Vin Shelton]

On Fri, Feb 6, 2009 at 11:33 AM, Peter Stephenson <pws@csr.com> wrote:
> On Fri, 6 Feb 2009 09:56:26 +0000
> Peter Stephenson <pws@csr.com> wrote:
>> On Thu, 5 Feb 2009 23:07:24 -0500
>> Vin Shelton <acs@alumni.princeton.edu> wrote:
>> > Under the soon-to-be-released Cygwin 1.7, I downloaded the latest CVS
>> > sources and ran a build from scratch.  I'm getting a test hang in D03:
>>
>> This is process substitution again.  This is problematic under Cygwin:
>> sometimes one of the two forms works, sometimes another, even though both
>> are notionally present and zsh is simply using documented behaviour that
>> works on other systems.  (The real problem, of course, is that process
>> handling is intrinsically horrific in Cygwin.)
>>
>> I don't think we can do much more than skip the test and put a warning
>> about related features in the manual.  We might be able to add an option to
>> pick the support we use (named pipes or device files) but that's probably
>> only of use to the sort of people who could in any case hack the
>> configuration by hand.
>
> ... in fact, could you try #define'ing PATH_DEV_FD in config.h (it's turned
> off by a special test in configure) and see if that works with the new
> version of Cygwin?  We can always reverse the configured default when that
> comes out.

Yes, that enables D03 to pass.  Thank you!

  - Vin

Re: Test D03 hang under cygwin 1.7

[Peter A. Castro]

On Thu, 5 Feb 2009, Vin Shelton wrote:

> Hello -

Greetings, Vin,

> Under the soon-to-be-released Cygwin 1.7, I downloaded the latest CVS
> sources and ran a build from scratch.  I'm getting a test hang in D03:

I've seen this only once before under 1.5, but not lately in any of my
test builds.  Are you running a multi-processor/hyper-threaded machine?
If so, what's the configuration?  At the point of the hang, do a 'ps' and
see how many zsh shells are currently running.  This might be a race
condition which can be coded around depending on the exact configuration
needed to cause the condition.

> ZTST_verbose=3 make TESTNUM=D03 check
> cd Test ; make check
> make[1]: Entering directory `/usr/local/build/zsh-2009-02-05/Test'
> if test -n "gcc"; then \
>          cd .. && DESTDIR= \
>          make MODDIR=`pwd`/Test/Modules install.modules > /dev/null; \
>        fi
> if ZTST_testlist="`for f in /usr/local/src/zsh-2009-02-05/Test/D03*.ztst; \
>           do echo $f; done`" \
>         ZTST_srcdir="/usr/local/src/zsh-2009-02-05/Test" \
>         ZTST_exe=../Src/zsh.exe \
>         ../Src/zsh.exe +Z -f
> /usr/local/src/zsh-2009-02-05/Test/runtests.zsh; then \
>         stat=0; \
>        else \
>         stat=1; \
>        fi; \
>        rm -rf Modules .zcompdump; \
>        exit $stat
> /usr/local/src/zsh-2009-02-05/Test/D03procsubst.ztst: starting.
> ZTST_getsect: read section name: prep
> ZTST_getchunk: read code chunk:
>  if grep '#define PATH_DEV_FD' $ZTST_testdir/../config.h > /dev/null 2>&1 ||
>     grep '#define HAVE_FIFOS' $ZTST_testdir/../config.h > /dev/null 2>&1; then
>    mkdir procsubst.tmp
>    cd procsubst.tmp
>    print 'First\tSecond\tThird\tFourth' >FILE1
>    print 'Erste\tZweite\tDritte\tVierte' >FILE2
>  else
>    ZTST_unimplemented="process substitution is not supported"
>    true
>  fi
> ZTST_execchunk: status 0
> ZTST_getchunk: read code chunk:
>  function copycat { cat "$@" }
> ZTST_execchunk: status 0
> ZTST_getchunk: read code chunk:
>
> ZTST_getsect: read section name: test
> ZTST_test: looking for new test
> ZTST_test: examining line:
>  paste <(cut -f1 FILE1) <(cut -f3 FILE2)
> ZTST_getchunk: read code chunk:
>  paste <(cut -f1 FILE1) <(cut -f3 FILE2)
> ZTST_test: examining line:
>> First  Dritte
> ZTST_getredir: read redir for '>':
> First   Dritte
> ZTST_test: examining line:
>
> Running test: <(...) substitution
> ZTST_test: expecting status: 0
> Input: /tmp/zsh.ztst.in.3712, output: /tmp/zsh.ztst.out.3712, error:
> /tmp/zsh.ztst.terr.3712
> make[1]: *** [check] Interrupt
> make: *** [check] Interrupt
>

-- 
Peter A. Castro <doctor@fruitbat.org> or <Peter.Castro@oracle.com>
 	"Cats are just autistic Dogs" -- Dr. Tony Attwood

Re: Test D03 hang under cygwin 1.7

[Vin Shelton]

Hello, Peter -

On Sat, Feb 7, 2009 at 1:32 AM, Peter A. Castro <doctor@fruitbat.org> wrote:
> On Thu, 5 Feb 2009, Vin Shelton wrote:
>> Under the soon-to-be-released Cygwin 1.7, I downloaded the latest CVS
>> sources and ran a build from scratch.  I'm getting a test hang in D03:
>
> I've seen this only once before under 1.5, but not lately in any of my
> test builds.  Are you running a multi-processor/hyper-threaded machine?
> If so, what's the configuration?

Yes - I'm running this on my core-2 duo, T7250.  What other
configuration info would you like?

> At the point of the hang, do a 'ps' and
> see how many zsh shells are currently running.  This might be a race
> condition which can be coded around depending on the exact configuration
> needed to cause the condition.

There are 2 instances of the shell running:
     3632    3956     404       1792    0 1003 22:48:00
/usr/local/build/zsh-2009-02-12/Src/zsh
     1760    3632     404       3128    0 1003 22:48:51
/usr/local/build/zsh-2009-02-12/Src/zsh

HTH,
  Vin