[PATCH] print errors to stderr

[PATCH] print errors to stderr

[isabella parakiss]

From 6fa7a56ee8cab083f4d9f4f13a2e1a11ff72bdef Mon Sep 17 00:00:00 2001
From: izabera <izaberina@gmail.com>
Date: Wed, 22 Jun 2016 08:44:57 +0200
Subject: [PATCH] print errors to stderr

---
 Src/builtin.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Src/builtin.c b/Src/builtin.c
index c2fb81e..891e203 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3633,8 +3633,8 @@ bin_whence(char *nam, char **argv, Options ops, int func)
 		}
 	    }
 	    if (!informed && (wd || v || csh)) {
-		zputs(*argv, stdout);
-		puts(wd ? ": none" : " not found");
+		zputs(*argv, stderr);
+		zputs(wd ? ": none" : " not found", stderr);
 		returnval = 1;
 	    }
 	    popheap();
@@ -3654,7 +3654,7 @@ bin_whence(char *nam, char **argv, Options ops, int func)
 	} else {
 	    /* Not found at all. */
 	    if (v || csh || wd)
-		zputs(*argv, stdout), puts(wd ? ": none" : " not found");
+		zputs(*argv, stderr), zputs(wd ? ": none" : " not found", stderr);
 	    returnval = 1;
 	}
     }
-- 
2.9.0


---
xoxo iza

Re: [PATCH] print errors to stderr

[Oliver Kiddle]

isabella parakiss wrote:
> Subject: [PATCH] print errors to stderr
> @@ -3633,8 +3633,8 @@ bin_whence(char *nam, char **argv, Options ops, int func)
> -		zputs(*argv, stdout);
> -		puts(wd ? ": none" : " not found");
> +		zputs(*argv, stderr);
> +		zputs(wd ? ": none" : " not found", stderr);

I think this behaviour is actually intentional. It is arguably not an
error - the whence command's purpose is to search for something and
report on whether it is found. So it doesn't rely on finding it. Also,
this is compatible with csh and tcsh - the which command was a csh thing
first.

Oliver

Re: [PATCH] print errors to stderr

[Bart Schaefer]

On Jun 22,  9:42am, Oliver Kiddle wrote:
} 
} I think this behaviour is actually intentional. It is arguably not an
} error - the whence command's purpose is to search for something and
} report on whether it is found. So it doesn't rely on finding it. Also,
} this is compatible with csh and tcsh - the which command was a csh thing
} first.

Maybe it's time for either the doc or a code comment to explain this,
because I recall having this same discussion with someone else several
months ago.

Re: [PATCH] print errors to stderr

[Oliver Kiddle]

Bart wrote:
> } I think this behaviour is actually intentional. It is arguably not an
> } error - the whence command's purpose is to search for something and
> } report on whether it is found. So it doesn't rely on finding it. Also,
> } this is compatible with csh and tcsh - the which command was a csh thing
> } first.
>
> Maybe it's time for either the doc or a code comment to explain this,

Sounds sensible.

Oliver

diff --git a/Src/builtin.c b/Src/builtin.c
index c2fb81e..bfb9e69 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3633,6 +3633,7 @@ bin_whence(char *nam, char **argv, Options ops, int func)
 		}
 	    }
 	    if (!informed && (wd || v || csh)) {
+		/* this is information and not an error so, as in csh, use stdout */
 		zputs(*argv, stdout);
 		puts(wd ? ": none" : " not found");
 		returnval = 1;
@@ -3652,7 +3653,7 @@ bin_whence(char *nam, char **argv, Options ops, int func)
 	    }
 	    informed = 1;
 	} else {
-	    /* Not found at all. */
+	    /* Not found at all. That's not an error as such so this goes to stdout */
 	    if (v || csh || wd)
 		zputs(*argv, stdout), puts(wd ? ": none" : " not found");
 	    returnval = 1;