From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: "Peter A. Castro" <doctor@fruitbat.org>
Cc: zzapper <david@tvis.co.uk>, zsh-workers@sunsite.dk, cygwin@cygwin.com
Subject: Re: zsh and line breaks
Date: Thu, 01 Apr 2004 11:09:56 +0200 [thread overview]
Message-ID: <25057.1080810596@trentino.logica.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.53.0403310935450.9892@gremlin.fruitbat.org>
"Peter A. Castro" wrote:
> > It is easy for us to add `#ifdef __CYGWIN__' around changes or #define
> > O_TEXT to zero on other systems so if you do correct the problem,
> > please send the changes back to us.
>
> There are about 43 open() calls which I've updated with the O_TEXT
> option. Having all those ifdef's seemed rather ugly (makes the code hard
> to look at, expectially when they are within a few lines of each other)
> so I took a more "elegent" approach, though you may want to revise it if
> it doesn't meet your style requirements :)
I can believe that adding ifdef's to all is ugly. That's what I meant
by "#define O_TEXT to zero on other systems" - just one thought on a
possible more "elegant" approach.
> Yep, I'm experimenting with this right now. As it stands, tests which
> print out to a file and then cat it back in (currently A04redirect and
> E01options) produce a diff, but don't otherwise seem to have any
> problems.
Are the diffs just the line endings? From what I understand, the
reported problems were with text files used as input to the shell (i.e.
scripts, sourced files, autoloaded functions and stdin). Quite whether
it is also right for redirected output, I wouldn't know.
Oliver
next prev parent reply other threads:[~2004-04-01 9:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <s38u10erwrz.fsf@ackusativ.ling.uu.se>
[not found] ` <1vvf60l9i7n4nlobcroik2le5ofe6v2rn4@4ax.com>
[not found] ` <Pine.LNX.4.53.0403291441160.5939@gremlin.fruitbat.org>
2004-03-30 9:32 ` Oliver Kiddle
2004-03-30 18:54 ` Peter A. Castro
2004-03-31 12:45 ` Oliver Kiddle
2004-03-31 17:53 ` Peter A. Castro
2004-04-01 9:09 ` Oliver Kiddle [this message]
2004-04-01 21:20 ` Peter A. Castro
2004-04-02 9:49 ` Dave Korn
2004-04-02 16:59 ` Peter A. Castro
2004-04-03 1:23 ` Peter A. Castro
2004-04-03 20:35 ` Bart Schaefer
2004-04-04 19:29 ` Peter Stephenson
2004-04-05 16:19 ` Peter A. Castro
2004-04-05 17:40 ` Peter Stephenson
2004-04-05 22:08 ` Peter A. Castro
2004-04-05 23:08 ` Clint Adams
2004-04-05 23:25 ` Peter A. Castro
2004-04-07 21:10 ` Clint Adams
2004-04-08 1:16 ` Peter A. Castro
2004-04-09 5:00 ` Felix Rosencrantz
2004-04-09 16:26 ` Peter A. Castro
2004-04-06 9:43 ` Peter Stephenson
2004-04-06 22:25 ` Peter A. Castro
2004-04-15 5:03 ` Clint Adams
2004-04-15 6:43 ` Peter A. Castro
2004-04-15 10:35 ` Clint Adams
2004-04-15 16:57 ` Peter A. Castro
2004-04-15 18:14 ` Clint Adams
2005-01-31 5:07 ` Patch for 4.2.3 building on Cygwin Peter A. Castro
2005-01-31 11:37 ` Peter Stephenson
2005-01-31 20:48 ` Peter A. Castro
2005-02-01 10:53 ` Peter Stephenson
2005-02-01 16:03 ` Bart Schaefer
2005-02-01 18:04 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25057.1080810596@trentino.logica.co.uk \
--to=okiddle@yahoo.co.uk \
--cc=cygwin@cygwin.com \
--cc=david@tvis.co.uk \
--cc=doctor@fruitbat.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).