zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _add-zsh-hook: add -L
Date: Tue, 01 May 2018 09:48:41 +0200	[thread overview]
Message-ID: <30998.1525160921@thecus> (raw)
In-Reply-To: <20180430123153.29371-1-genml+zsh-workers@thequod.de>

Daniel Hahler wrote:
>
> --- a/Completion/Zsh/Function/_add-zsh-hook

> @@ -14,8 +14,9 @@ _add-zsh-hook() {
> -    '(-D)-d[remove HOOK from the array]' \
> -    '(-d)-D[interpret HOOK as pattern to remove from the array]' \
> +    '(-D,-L)-d[remove HOOK from the array]' \
> +    '(-d,-L)-D[interpret HOOK as pattern to remove from the array]' \
> +    '(-d,-D)-L[list current values of the array with typeset]' \

You need spaces rather commas inside the exclusion list.

I'd also convert HOOK to lowercase while you're there. Those
descriptions look like they have been copied and pasted from
documentation where full usage has been presented first - something
like:

    add-zsh-hook [ -L | -dD ] [ -Uzk ] HOOK FUNCTION

In completion, we're not presenting the information that the first
normal argument is 'HOOK'.

Oliver


  reply	other threads:[~2018-05-01  7:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 12:31 Daniel Hahler
2018-05-01  7:48 ` Oliver Kiddle [this message]
2018-05-01  8:56   ` [PATCH] _add-zsh-hook: add -L and improve descriptions Daniel Hahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30998.1525160921@thecus \
    --to=okiddle@yahoo.co.uk \
    --cc=genml+zsh-workers@thequod.de \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).