zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh workers <zsh-workers@zsh.org>
Subject: pull requests for completion functions
Date: Thu, 09 Nov 2017 17:20:59 +0100	[thread overview]
Message-ID: <31167.1510244459@thecus.kiddle.eu> (raw)

I have tentatively added a short line to the bottom of the contributing
section of the web pages to indicate that completions are acceptable in
the form of pull/merge requests. The link is here:

  http://zsh.sourceforge.net/Arc/git.html

Can I take silence to mean that people were happy with my suggestion on
this new policy? If not then please speak now, reverting the web page is
easily done.

My intended procedure for managing pull requests is as follows.

First you need to add separate remote repositories:
  git remote add gitlab https://gitlab.com/zsh-org/zsh.git
  git remote add github https://github.com/zsh-users/zsh.git

There's a variety of ways to fetch pull requests directly but I add a line
in .git/config under each section:

  under: [remote "gitlab"]
  add:       fetch = +refs/merge-requests/*/head:refs/remotes/gitlab/merge-requests/*
  under: [remote "github"]
  add:       fetch = +refs/pull/*:refs/remotes/github/pr/*

Many projects use merges but, to keep things as consistent as possible
with current practices, for now I would cherry-pick individual pull
requests and amend the commit to add a ChangeLog entry and reference
to the commit message. For ChangeLog entries and commit messages, the
references might be something like "MR: #1". Or do we need to be more
explicit, e.g. "github PR: #1"?

Any comments or suggestions would be welcome.

Oliver


             reply	other threads:[~2017-11-09 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 16:20 Oliver Kiddle [this message]
2017-11-09 17:32 ` Peter Stephenson
2017-11-10 22:14   ` Alex George
2017-11-10 23:57     ` Oliver Kiddle
2017-11-10 22:42 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31167.1510244459@thecus.kiddle.eu \
    --to=okiddle@yahoo.co.uk \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).