From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Alex George <xzeroknightx@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: pull requests for completion functions
Date: Sat, 11 Nov 2017 00:57:41 +0100 [thread overview]
Message-ID: <4312.1510358261@thecus.kiddle.eu> (raw)
In-Reply-To: <CANKG6XrmFhTXyfirVWn_kHNHJGNEkQT8eNQyVuP9XKXrPRAVCA@mail.gmail.com>
Alex George wrote:
> No objections here. I think it would be especially useful for large
> patches. However, if someone were to use git{hub,lab} to submit a PR,
> should they send a message about it to the list? If so, should discussion
> about the patch take place on the list, or on git{hub,lab}? What should the
> mailing list subject be? Should the body simply contain a link to the PR?
The motivation is to make it easier for casual contributors to submit
completion function related patches. I was planning to keep interaction
related to pull/merge requests on git{hub,lab} and only move to the
list if questions related to the core parts of completion come up. When
discussing a proposed patch, it's often useful to quote parts of both
patch and commentary so I'm not sure how constructive it would be if the
patch is on gitlab and the explanatory remarks go to the list.
Sending completion function patches to the mailing list will also
continue to be perfectly acceptable. I'll probably continue to do things
that way myself. Perhaps we should lower the threshold of what gets
pushed unposted with completion functions to reduce noise on the list(?)
I'm not sure I see a problem with large patches on the mailing list but
until now, my experience with git{lab,hub} is relatively limited. So I'm
open to suggestions.
Oliver
next prev parent reply other threads:[~2017-11-10 23:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 16:20 Oliver Kiddle
2017-11-09 17:32 ` Peter Stephenson
2017-11-10 22:14 ` Alex George
2017-11-10 23:57 ` Oliver Kiddle [this message]
2017-11-10 22:42 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4312.1510358261@thecus.kiddle.eu \
--to=okiddle@yahoo.co.uk \
--cc=xzeroknightx@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).