From: Oliver Kiddle <opk@zsh.org>
To: Nicholas Vinson <nvinson234@gmail.com>
Cc: Bart Schaefer <schaefer@brasslantern.com>, zsh-workers@zsh.org
Subject: Re: [PATCH 0/2] incompatible-poiner-types bug fixes
Date: Tue, 12 Dec 2023 00:55:00 +0100 [thread overview]
Message-ID: <34968-1702338900.962633@DDgj.sPkf.ifzO> (raw)
In-Reply-To: <3a2be586-89ce-4eac-b889-2a6cd8a38d72@gmail.com>
Nicholas Vinson wrote:
> If configure incorrectly decides (or is incorrectly told) that boolcodes
> or numcodes do not exist, you end up with a naming conflict at
> compile-time. This happened while I was testing my changes. I suspect,
It may be for the best that we get errors if configure has got things
wrong.
> Moreover, these changes align the handling of all three variables,
> boolcodes, numcodes, strcodes, in a type-safe and name-safe manner.
If adding const makes the code align with ncurses then that could be
useful. But the #defines seem ugly and unnecessary.
Oliver
prev parent reply other threads:[~2023-12-11 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 21:49 Nicholas Vinson
2023-12-10 22:45 ` Bart Schaefer
2023-12-10 23:31 ` Nicholas Vinson
2023-12-11 23:55 ` Oliver Kiddle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34968-1702338900.962633@DDgj.sPkf.ifzO \
--to=opk@zsh.org \
--cc=nvinson234@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).