From: Nicholas Vinson <nvinson234@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 0/2] incompatible-poiner-types bug fixes
Date: Sun, 10 Dec 2023 18:31:03 -0500 [thread overview]
Message-ID: <3a2be586-89ce-4eac-b889-2a6cd8a38d72@gmail.com> (raw)
In-Reply-To: <CAH+w=7aYcRqLhyNFMkmXZfxkLThtxPqYBt0qxXamhoOa8FyOWA@mail.gmail.com>
If configure incorrectly decides (or is incorrectly told) that boolcodes
or numcodes do not exist, you end up with a naming conflict at
compile-time. This happened while I was testing my changes. I suspect,
but don't know for sure, that this also happened at some point with
strcodes since the handling of that variable is different than how
boolcodes and numcodes are handled. Regardless, the naming change
prevents the naming conflict, and the defines prevent added complexity
on the for-loops and simplifies the strcodes for-loop handling.
Moreover, these changes align the handling of all three variables,
boolcodes, numcodes, strcodes, in a type-safe and name-safe manner.
Thanks,
Nicholas Vinson
On 12/10/23 17:45, Bart Schaefer wrote:
> On Sun, Dec 10, 2023 at 1:50 PM Nicholas Vinson <nvinson234@gmail.com> wrote:
>> This patch series fixes several bugs found by compiling with
>> -Werror=incompatible-pointer-types.
> We've already got a patch for this from Florian Weimer
> <fweimer@redhat.com> in workers/52383. Is the zboolcodes naming and
> BOOLCODES define in Src/Modules/termcap.c actually necessary?
next prev parent reply other threads:[~2023-12-10 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 21:49 Nicholas Vinson
2023-12-10 22:45 ` Bart Schaefer
2023-12-10 23:31 ` Nicholas Vinson [this message]
2023-12-11 23:55 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a2be586-89ce-4eac-b889-2a6cd8a38d72@gmail.com \
--to=nvinson234@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).