bug in sed completion

bug in sed completion

[Marc Chantreux]

Hi all,

I've discovered a bug in the sed -i completion :

% sed -i <tab>
suffix for backup
sed script

that's right ... but :

% sed -i 's/x//' <tab>
sed script

wrong ! sed script already written, it's time to give sed filenames.

I'm sorry to not submit a patch but i'm still not skilled with
completion.

regards
mc

Re: bug in sed completion

[Dan Nelson]

In the last episode (Nov 09), Marc Chantreux said:
> Hi all,
> 
> I've discovered a bug in the sed -i completion :
> 
> % sed -i <tab>
> suffix for backup
> sed script
> 
> that's right ... but :
> 
> % sed -i 's/x//' <tab>
> sed script
> 
> wrong ! sed script already written, it's time to give sed filenames.

Doesn't that mean you want your backup extension to be "s/x//" ?  If
you don't want a backup, use -i "".

-- 
	Dan Nelson
	dnelson@allantgroup.com

Re: bug in sed completion

[Marc Chantreux]

Dan Nelson a écrit :

>Doesn't that mean you want your backup extension to be "s/x//" ?
>
no, it means that i don't need backup ( i alreasy have one in my DAT ;-) ).

> If
>you don't want a backup, use -i "".
>  
>
sed don't need it, so the zsh completion don't have to (IMHO).

regards

Re: bug in sed completion

[Bart Schaefer]

On Nov 10, 12:02am, Marc Chantreux wrote:
} Subject: Re: bug in sed completion
}
} Dan Nelson a écrit :
} 
} >Doesn't that mean you want your backup extension to be "s/x//" ?
} >
} no, it means that i don't need backup ( i alreasy have one in my DAT ;-) ).

If I'm reading the GNU sed docs correctly, the following patch should do
it.  Of course the first chunk of this is probably wrong for non-GNU with
--expression / --file, but I no longer have access to anything but Linux
machines so someone else will have to fix up that part.

This also fixes a typo (too many sss).

Index: Completion/Unix/Command/_sed
===================================================================
diff -c -r1.1 _sed
--- Completion/Unix/Command/_sed	12 Mar 2004 18:05:54 -0000	1.1
+++ Completion/Unix/Command/_sed	10 Nov 2005 03:44:47 -0000
@@ -4,16 +4,16 @@
 
 args=(
   '(-n --quiet --silent)'{-n,--quiet,--silent}'[suppress automatic printing of pattern space]'
-  '(1)*'{-e,--expresssion=}'[add sed commands to run]:sed script'
-  '(1)*'{-f,--file=}'[add contents of file to commands to run]:file:_files'
+  '(1)*'{-e,--expression=-}'[add sed commands to run]:sed script'
+  '(1)*'{-f,--file=-}'[add contents of file to commands to run]:file:_files'
   '(-e)1: :_guard "^-*" sed script'
   ':input file:_files'
 )
 
 if _pick_variant gnu=GNU unix --version; then
   args+=(
-    '(-i --in-place)'{-i,--in-place=}'[edit files in place]::suffix for backup'
-    '(-l --line-length)'{-l,--line-length=}'[specify line-wrap length for the l command]'
+    '(-i --in-place)'{-i-,--in-place=-}'[edit files in place]::suffix for backup'
+    '(-l --line-length)'{-l,--line-length=-}'[specify line-wrap length for the l command]'
     '(-r --regexp-extended)'{-r,--regexp-extended}'[use extended regular expressions]'
     '(-s --separate)'{-s,--separate}'[consider files separately instead of as a combined stream]'
     '(-u --unbuffered)'{-u,--unbuffered}'[disable data buffering]'


-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: bug in sed completion

[Marc Chantreux]

Bart Schaefer wrote:

i have applied your patch but it has no effect. peraps because i failed 
to recompile Completion.zwc.

To be sure : i've used zsh Completion.zwc Completion/**/_*(^/)

regards

Re: bug in sed completion

[Bart Schaefer]

On Nov 10,  9:15am, Marc Chantreux wrote:
}
} i have applied your patch but it has no effect. peraps because i failed 
} to recompile Completion.zwc.

That must be it.  Works for me:

zsh% sed -i<TAB>
Completing suffix for backup
Completing option
--in-place  -- edit files in place
zsh% sed -i <TAB>
Completing sed script
zsh% sed -i s/x/y/ <TAB>
Completing input file

} To be sure : i've used zsh Completion.zwc Completion/**/_*(^/)

I don't know what that means.

Re: bug in sed completion

[Marc Chantreux]

Bart Schaefer wrote:

> That must be it.  Works for me

so i'll find the way to compile completion definitions by myself. Thanks 
for your help!

regards

mc