zsh-workers
 help / color / mirror / code / Atom feed
From: m0viefreak <m0viefreak.cm@googlemail.com>
To: zsh-workers@zsh.org
Subject: [PATCH] zle: Call zle-line-pre-redraw after inserting a completion result
Date: Sat, 8 Oct 2016 19:30:16 +0200	[thread overview]
Message-ID: <43c19ce7-6445-8b56-68e7-60fc82258183@googlemail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]


This patch originated from a zsh-synatx-highlighting issue:
https://github.com/zsh-users/zsh-syntax-highlighting/issues/375

I think redrawhook() should be called at the end of do_single()
to make sure that zle-line-pre-redraw is run when cycling the results of
a menu completion.


By the way (unrelated):

The hooks (which served me as entry point for finding the right spot for
the path)

#define INSERTMATCHHOOK     (comphooks + 0)
#define MENUSTARTHOOK       (comphooks + 1)
#define COMPCTLMAKEHOOK     (comphooks + 2)
#define COMPCTLCLEANUPHOOK  (comphooks + 3)
#define COMPLISTMATCHESHOOK (comphooks + 4)
...
struct hookdef comphooks[] = {
    HOOKDEF("insert_match", NULL, HOOKF_ALL),
    HOOKDEF("menu_start", NULL, HOOKF_ALL),
    HOOKDEF("compctl_make", NULL, 0),
    HOOKDEF("compctl_cleanup", NULL, 0),
    HOOKDEF("comp_list_matches", ilistmatches, 0),
};

seem to be undocumented.

[-- Attachment #2: 0001-zle-Call-zle-line-pre-redraw-after-inserting-a-compl.patch --]
[-- Type: text/plain, Size: 723 bytes --]

From 6c1e1fe71011f8617a85fb2d53b7a36c8fcd0d07 Mon Sep 17 00:00:00 2001
From: m0viefreak <m0viefreak.cm@googlemail.com>
Date: Sat, 8 Oct 2016 18:53:55 +0200
Subject: [PATCH] zle: Call zle-line-pre-redraw after inserting a completion
 result

This is necessary to make sure redrawhook() is called while
cycling results in menu completion.
---
 Src/Zle/compresult.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Src/Zle/compresult.c b/Src/Zle/compresult.c
index 7fec7c8..b7ec18f 100644
--- a/Src/Zle/compresult.c
+++ b/Src/Zle/compresult.c
@@ -1191,6 +1191,7 @@ do_single(Cmatch m)
 	if (menucmp)
 	    minfo.cur = &m;
 	runhookdef(INSERTMATCHHOOK, (void *) &dat);
+	redrawhook();
 	minfo.cur = om;
     }
 }
-- 
2.8.3


             reply	other threads:[~2016-10-08 18:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-08 17:30 m0viefreak [this message]
2016-10-11  3:03 ` Bart Schaefer
2016-10-16 15:13 ` Daniel Shahaf
2016-10-17  8:39   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43c19ce7-6445-8b56-68e7-60fc82258183@googlemail.com \
    --to=m0viefreak.cm@googlemail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).