From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] zle: Call zle-line-pre-redraw after inserting a completion result
Date: Mon, 17 Oct 2016 09:39:02 +0100 [thread overview]
Message-ID: <20161017093902.0a7dd896@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20161016151354.GA21942@fujitsu.shahaf.local2>
On Sun, 16 Oct 2016 15:13:54 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> m0viefreak wrote on Sat, Oct 08, 2016 at 19:30:16 +0200:
> > This patch originated from a zsh-synatx-highlighting issue:
> > https://github.com/zsh-users/zsh-syntax-highlighting/issues/375
> >
> > I think redrawhook() should be called at the end of do_single()
> > to make sure that zle-line-pre-redraw is run when cycling the results of
> > a menu completion.
>
> Any thoughts on the patch? With my z-sy-h hat, I confirm it behaves as
> promised (applies highlighting whilst tabbing through menu completion),
> but with my zsh hat, I am not familiar with zle enough to review this
> patch.
I can't see anything obviously wrong with it.
pws
prev parent reply other threads:[~2016-10-17 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 17:30 m0viefreak
2016-10-11 3:03 ` Bart Schaefer
2016-10-16 15:13 ` Daniel Shahaf
2016-10-17 8:39 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017093902.0a7dd896@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).