zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Completion for aplay from alsa-utils
Date: Mon, 04 Nov 2019 11:38:37 +0100	[thread overview]
Message-ID: <4405-1572863917.383938@MoYM.5_T_.gyV0> (raw)
In-Reply-To: <EE6F9F27-FFCB-4D88-91E7-C0EE5CF33C4D@dana.is>

dana wrote:
> On 2 Nov 2019, at 16:13, Sebastian Gniazdowski <sgniazdowski@gmail.com> wrote:
> > the submitted completion is in file _alsa-utils
>
> Feels like maybe it should just be called _aplay, unless you think there would
> be so much shared code between future alsa-utils completion functions that
> they all need to live together in one (not sure but doesn't seem like it)

I don't agree on this point.
There often is shared code between utilities that come from the same
source. As you even point out, arecord takes essentially the same set of
options. And _alsa-utils makes it clearer where aplay comes from if it
isn't clear. We've also got plenty of existing functions where naming
matches to package or source rather than the command. It can also make
it easier to handle name clashes if a different aplay turns up.

Oliver

  reply	other threads:[~2019-11-04 10:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02 21:13 Sebastian Gniazdowski
2019-11-03 23:17 ` dana
2019-11-04 10:38   ` Oliver Kiddle [this message]
2019-11-21 23:10   ` Sebastian Gniazdowski
2019-11-22  3:05     ` dana
2019-11-25 10:16       ` Sebastian Gniazdowski
2019-11-25 12:10         ` Sebastian Gniazdowski
2019-11-26  2:16           ` dana
2019-12-01 21:11             ` Sebastian Gniazdowski
2019-11-22 15:17     ` Eric Cook
2019-11-25  9:27       ` Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4405-1572863917.383938@MoYM.5_T_.gyV0 \
    --to=okiddle@yahoo.co.uk \
    --cc=sgniazdowski@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).