zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <opk@zsh.org>
To: Marc Chantreux <eiro@phear.org>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: 2 new patches for _surfraw
Date: Sun, 11 Apr 2021 22:23:20 +0200	[thread overview]
Message-ID: <50073-1618172600.354479@MZYm.HwWc.l_LS> (raw)
In-Reply-To: <YHFkB2PYXxZ2kIm0@prometheus.u-strasbg.fr>

Marc Chantreux wrote:
> +++ b/Completion/Unix/Command/_surfraw
>  #compdef surfraw sr
> +# vim: et ts=2

We have a .editorconfig file in the root of the source tree that
declares this in an editor neutral manner. A plugin for vim exists to
use it. While I do use vim, I don't have, e.g. less configured for a
tabsize of 2. The expandtab option is fine but I go with shiftwidth=2
and leave the tabsize at the default 8.
Your patch even looks like you've fixed the tabs with the equivalent of
expand -t2

I have pushed the various patches including whitespace fixups. If
anything seems missing, let me know. Preferably pull from git for any
further patches to ensure they're against the latest state of HEAD.

Thanks

Oliver


  reply	other threads:[~2021-04-11 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 19:49 Marc Chantreux
2021-04-09 21:53 ` Oliver Kiddle
2021-04-09 23:10   ` Daniel Shahaf
2021-04-10  0:05     ` Oliver Kiddle
2021-04-10  8:38   ` Marc Chantreux
2021-04-11 20:23     ` Oliver Kiddle [this message]
2021-04-12  8:23       ` Marc Chantreux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50073-1618172600.354479@MZYm.HwWc.l_LS \
    --to=opk@zsh.org \
    --cc=eiro@phear.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).