zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Baptiste BEAUPLAT <lyknode@cilg.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Completion for sbuild
Date: Mon, 16 Dec 2019 12:20:43 +0100	[thread overview]
Message-ID: <5873-1576495243.685540@E5gB.6FIY.i_D2> (raw)
In-Reply-To: <583f56f7-9d85-faf9-61f9-e07b6b40e07c@cilg.org>

On 10 Dec, Baptiste BEAUPLAT wrote:
> Thanks a lot for taking the time to review this patch, that greatly
> appreciated. I'll try to fix as much as I can do.

I don't know if Daniel had any further comments on this but it looked
good to me so I've merged it with a couple of very minor tweaks.
Anything else can always be handled with patches.

> +        if [[ -n "${DEBFULLNAME}" ]]; then
> +            identity = "${DEBFULLNAME} <${DEBEMAIL}>"
> +        else
> +            identity = "${DEBEMAIL}"
> +        fi

I removed the spaces either side of the = in these assignments as this
will attempt to run an `identity' command instead.

Thanks for the contribution and for taking the time to go over the
feedback and revise it.

Oliver

      reply	other threads:[~2019-12-16 11:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 19:53 Baptiste BEAUPLAT
2019-08-23  4:40 ` Daniel Shahaf
2019-12-10 10:20   ` Baptiste BEAUPLAT
2019-12-16 11:20     ` Oliver Kiddle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5873-1576495243.685540@E5gB.6FIY.i_D2 \
    --to=okiddle@yahoo.co.uk \
    --cc=lyknode@cilg.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).