From: Oliver Kiddle <opk@zsh.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: pcre callouts
Date: Fri, 03 Nov 2023 10:50:34 +0100 [thread overview]
Message-ID: <64457-1699005034.369027@7IEn.q_Gt.fe0Q> (raw)
In-Reply-To: <CAH+w=7ZXiPkDRaW+QjdKpZ3+ghk5-0wzj_dBr+maFJ8igu4x0A@mail.gmail.com>
Bart Schaefer wrote:
> I didn't try applying the previous patch, but now that this one has
> been pushed to sourceforge:
I'm less sure on whether to push the later one for setting a scope.
And perhaps whether to add a -f option to pcre_match for a fixed callout
function that can avoid shell evaluation and handle numeric callouts.
> pcre.c: In function ‘pcre_callout’:
> pcre.c:132:44: error: parameter name omitted
> 132 | pcre_callout(pcre2_callout_block_8 *block, void *)
> | ^~~~~~
Sorry, I think the following form should be right.
Oliver
diff --git a/Src/Modules/pcre.c b/Src/Modules/pcre.c
index e6b59831f..e48ae3ae5 100644
--- a/Src/Modules/pcre.c
+++ b/Src/Modules/pcre.c
@@ -129,7 +129,7 @@ bin_pcre_study(char *nam, UNUSED(char **args), UNUSED(Options ops), UNUSED(int f
}
static int
-pcre_callout(pcre2_callout_block_8 *block, void *)
+pcre_callout(pcre2_callout_block_8 *block, UNUSED(void *callout_data))
{
Eprog prog;
int ret=0;
next prev parent reply other threads:[~2023-11-03 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 0:04 Oliver Kiddle
2023-10-31 3:26 ` Bart Schaefer
2023-10-31 3:40 ` Bart Schaefer
2023-10-31 13:31 ` Mikael Magnusson
2023-10-31 15:57 ` Bart Schaefer
2023-11-01 2:04 ` Oliver Kiddle
2023-11-03 3:47 ` Bart Schaefer
2023-11-03 9:50 ` Oliver Kiddle [this message]
2023-11-04 20:57 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64457-1699005034.369027@7IEn.q_Gt.fe0Q \
--to=opk@zsh.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).