zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: PATCH: typeset: Fix leaving corrupted entries in paramtab
Date: Fri, 5 Jun 2020 14:58:19 +0100 (BST)	[thread overview]
Message-ID: <650622554.469269.1591365499237@mail2.virginmedia.com> (raw)
In-Reply-To: <20200605134208.32082-1-mikachu@gmail.com>

> On 05 June 2020 at 14:42 Mikael Magnusson <mikachu@gmail.com> wrote:
> This appears to fix the problem in 45984, but I would appreciate someone
> checking if it seems sane and/or complete.

Looks sane to me --- those are three cases where we've just created a new
parameter for some special purpose (which then failed), which isn't typical
in that function as it can operate on existing parameters too, so
additional action at those specific points is correct.

pws

  reply	other threads:[~2020-06-05 13:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05 13:42 Mikael Magnusson
2020-06-05 13:58 ` Peter Stephenson [this message]
2020-06-05 15:56   ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650622554.469269.1591365499237@mail2.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).