zsh-workers
 help / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Kamil Dudka <kdudka@redhat.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
Date: Fri, 28 Jun 2019 01:01:25 +0200
Message-ID: <797-1561676485.902916@C-Cf.WCnE.5Cn6> (raw)
In-Reply-To: <20190626101908.548-1-kdudka@redhat.com>

Kamil Dudka wrote:
> There is a bug report in Red Hat Bugzilla about zsh crashing on NULL
> pointer dereference: https://bugzilla.redhat.com/1722703
>
> I was not able to reproduce the crash myself but the attached patch
> should prevent zsh from crashing in this situation.

It'd perhaps be good to add a DPUTS call here because while it is good
not to crash the condition does perhaps indicate a bug and it'd be
better not to hide it completely. I can't reproduce the crash either but
there must be some plugins or url quoting magic going on here.
More details of the setup used by the user might help find the
underlying problem.

Oliver

  parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 10:19 Kamil Dudka
     [not found] ` <249696510.1723352.1561545091592@mail2.virginmedia.com>
2019-06-26 11:00   ` Fwd: " Peter Stephenson
2019-06-26 12:07     ` Kamil Dudka
2019-06-27 23:01 ` Oliver Kiddle [this message]
2019-06-28  0:20   ` Mikael Magnusson
2019-06-28  8:12   ` Kamil Dudka
2019-07-23 13:45   ` [PATCH v2] " Kamil Dudka
2019-07-26 15:24     ` Kamil Dudka

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=797-1561676485.902916@C-Cf.WCnE.5Cn6 \
    --to=okiddle@yahoo.co.uk \
    --cc=kdudka@redhat.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/ public-inbox