From: dana <dana@dana.is>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] rewrite _killall
Date: Thu, 28 Jun 2018 09:52:05 -0500 [thread overview]
Message-ID: <7EC1FE8D-1B43-4EC2-A787-FC51E5202341@dana.is> (raw)
In-Reply-To: <C3A7A339-300C-4D7A-8F24-5165BB927115@kba.biglobe.ne.jp>
On 28 Jun 2018, at 02:39, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>+if _pick_variant psmisc=PSmisc unix --version; then
Is this OK? I know it's checking for killall5/Solaris early on, but is there any
possibility that a SysV-style killall could slip past that check? Maybe that's
overly paranoid, idk.
On 28 Jun 2018, at 02:39, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>+ '(-n --ns)'{-n,--ns}'[match against the PID namespace of the given PID]:pid: _pids'
Trivial thing, but it seems preferable to let _pids, _signals, &c., handle their
descriptions unless there's a specific need to override them, yeah?
On 28 Jun 2018, at 02:39, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>+ '(-g --process-group)'{-g,--process-group}'[kill the process group to which the process blongs]'
>+ '(-s --signal)'{-s,--signal}'[send the speified signal]:signal:_signals'
>+ '-m[interprit specified name as a regular expression]'
>+ '-s[show only what will be done, but do notsend any signal]'
Some typos here:
* blongs -> belongs
* speified -> specified
* interprit -> interpret
* notsend -> not send
On 28 Jun 2018, at 02:39, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>'(-u --user)'{-u,--user}'[kill only processes owned by specified user]: : _users'
>+ '-u[limit to processes belonging to specified user]: :_users'
These should all be in -o+ and --opt= form, i'd think.
On 28 Jun 2018, at 02:39, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>+ _arguments -s -S : $args
`-A '-*'` would be appropriate for this one.
dana
next prev parent reply other threads:[~2018-06-28 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 7:39 Jun T
2018-06-28 13:10 ` Jun T.
2018-06-28 14:52 ` dana [this message]
2018-06-29 11:45 ` Jun T
2018-07-01 16:17 ` Jun T.
2018-07-01 19:14 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7EC1FE8D-1B43-4EC2-A787-FC51E5202341@dana.is \
--to=dana@dana.is \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).