From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Make the parameter expansion subscript flags parse error message, "error in flags", identify the location of the parse error.
Date: Sun, 04 Apr 2021 17:27:05 +0100 [thread overview]
Message-ID: <7a5b055845089cfd55bb0a37fce66a5cbc47c9d5.camel@ntlworld.com> (raw)
In-Reply-To: <20210403024954.4321-1-danielsh@tarpaulin.shahaf.local2>
On Sat, 2021-04-03 at 02:49 +0000, Daniel Shahaf wrote:
> ---
> Review of the logic obtaining and massaging str_copy_for_output would be
> appreciated. It's a 2500-line function and there are multiple char*
> variables that refer to the same memory locations as *str, so it's
> conceivable I overlooked something.
I think this is early enough in the function it should be fine. It's
moving from left to right except where it needs to find something
matching, and the flags are first.
pws
prev parent reply other threads:[~2021-04-04 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 2:49 Daniel Shahaf
2021-04-04 16:27 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a5b055845089cfd55bb0a37fce66a5cbc47c9d5.camel@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).