From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: allow multiple completion for gcc -Wsuggest-attribute
Date: Tue, 13 Nov 2018 12:29:12 +0100 [thread overview]
Message-ID: <80822-1542108552.248661@XFOT.4sV7.4WEJ> (raw)
In-Reply-To: <CAHYJk3TBacH7jOv0UXpgXu8NeP0AnAue5Qhav3shi8_HfDovZQ@mail.gmail.com>
Mikael Magnusson wrote:
> Is there a specific reason you changed "Warn" to be lower case
> inconsistent with all the other descriptions here?
Lower case is the normal convention for completion functions and I
apply corrections for common things like that on lines that I'm
otherwise modifying. I can see that in this particular case, it is
rather less than ideal because there's a lot of similar options.
The trouble with big patches to correct things like case and indentation
is that they obscure history in git.
In the case of gcc, I'd be inclined to treat warnings as a single -W
option that takes an argument:
'*-W-[enable/disable a warning]:warning:->warnings'
Then parse the output of gcc --help=warnings and strip off the then
superfluous "Warn (about|when|if) " part of the descriptions.
Oliver
prev parent reply other threads:[~2018-11-13 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 1:44 Oliver Kiddle
2018-11-12 13:38 ` Mikael Magnusson
2018-11-13 11:29 ` Oliver Kiddle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80822-1542108552.248661@XFOT.4sV7.4WEJ \
--to=okiddle@yahoo.co.uk \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).