zsh-workers
 help / color / mirror / Atom feed
* PATCH: correction to losetup completion for creation mode
@ 2021-08-25 10:38 Oliver Kiddle
  0 siblings, 0 replies; only message in thread
From: Oliver Kiddle @ 2021-08-25 10:38 UTC (permalink / raw)
  To: Zsh workers

I noticed a lack of expected file completion in the second argument to
losetup for setting up a device and it seems that mode isn't right in
the completion. This should fix it.

Oliver

diff --git Completion/Linux/Command/_losetup Completion/Linux/Command/_losetup
index 54debe19e..f5a7ec1b1 100644
--- Completion/Linux/Command/_losetup
+++ Completion/Linux/Command/_losetup
@@ -33,14 +33,15 @@ _arguments -s -S \
   {-D,--detach-all}'[detach all associated loop devices]' \
   - 'create' \
   '--direct-io[open backing file with O_DIRECT]::enable:(on off)' \
-  '(-f --find 2)'{-f,--find}'[find the first unused loop device]' \
+  '(-f --find 1)'{-f,--find}'[find the first unused loop device]' \
   '(-L --nooverlap)'{-L,--nooverlap}'[avoid possible conflict between devices]' \
   '(-P --partscan)'{-P,--partscan}'[scan the partition table of newly created loop devices]' \
   '--sizelimit[limit device to specified size]:size (bytes)' \
   '(-b --sector-size)'{-b+,--sector-size=}'[set logical sector size of loop device]:size (bytes)' \
   '--show[print device name after setup]' \
   '(-r --read-only)'{-r,--read-only}'[set up a read-only loop device]' \
-  '1:file:_files' \
+  "(-f)$device" \
+  '2:file:_files' \
   - 'assoc' \
   '(-j --associated)'{-j,--associated}'[show the status of all loop devices associated with an file]:associated file:_files' \
   "(-f)$device"


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-25 10:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 10:38 PATCH: correction to losetup completion for creation mode Oliver Kiddle

zsh-workers

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/zsh-workers

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-workers zsh-workers/ https://inbox.vuxu.org/zsh-workers \
		zsh-workers@zsh.org
	public-inbox-index zsh-workers

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git