zsh-workers
 help / color / mirror / code / Atom feed
* PATCH: fixing _subversion
@ 2009-05-31 15:04 Akinori MUSHA
  0 siblings, 0 replies; 4+ messages in thread
From: Akinori MUSHA @ 2009-05-31 15:04 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

Hi,

The compdef for svnadmin has a typo that prevents REPOS_PATH
completion from working.  Apply the following patch to fix it.

Index: Completion/Unix/Command/_subversion
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_subversion,v
retrieving revision 1.27
diff -u -r1.27 _subversion
--- Completion/Unix/Command/_subversion	22 May 2009 15:48:32 -0000	1.27
+++ Completion/Unix/Command/_subversion	31 May 2009 06:35:24 -0000
@@ -150,7 +150,7 @@
         args=(
           ${=${${${(M)${(f)"$(LC_ALL=C _call_program options svnadmin help $cmd)"#(*Valid options:|(#e))}:#* :*}%% #:*}/ (arg|ARG)/:arg:}/(#b)-([[:alpha:]]) \[--([a-z-]##)\](:arg:)#/(--$match[2])-$match[1]$match[3] (-$match[1])--$match[2]$match[3]}
         )
-        if [[ $_svnadmin_subcmd_usage == *REPOS_PATH* ]]; then
+        if [[ $usage == *REPOS_PATH* ]]; then
           args+=( ":path:_files -/" )
         elif [[ $cmd = help ]]; then
           args+=( "*:subcommand:_svnadmin_commands" )


Regards,

--
Akinori MUSHA / http://akinori.org/

[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: PATCH: fixing _subversion
  2009-06-01 17:56 Akinori MUSHA
@ 2009-06-02  8:48 ` Peter Stephenson
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Stephenson @ 2009-06-02  8:48 UTC (permalink / raw)
  To: Akinori MUSHA, zsh-workers

"Akinori MUSHA" wrote:
> [Peter, I am mailing you because zsh-workers@ does not seem to accept
> my mail and cvs log showed that you have been working on the file in
> question below.]
> 
> The compdef for svnadmin has a typo that prevents REPOS_PATH
> completion from working.  Apply the following patch to fix it.

Thanks, I've applied this.

(I've also update the shell version recorded in the archive to
4.3.10-dev-1 to avoid installation conflicts with the released version,
but I'm too lazy to announce it separately.)

> Index: Completion/Unix/Command/_subversion
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_subversion,v
> retrieving revision 1.27
> diff -u -r1.27 _subversion
> --- Completion/Unix/Command/_subversion	22 May 2009 15:48:32 -0000
> 	1.27
> +++ Completion/Unix/Command/_subversion	31 May 2009 06:35:24 -0000
> @@ -150,7 +150,7 @@
>          args=(
>            ${=${${${(M)${(f)"$(LC_ALL=C _call_program options svnadmin help $
> cmd)"#(*Valid options:|(#e))}:#* :*}%% #:*}/ (arg|ARG)/:arg:}/(#b)-([[:alpha:
> ]]) \[--([a-z-]##)\](:arg:)#/(--$match[2])-$match[1]$match[3] (-$match[1])--$
> match[2]$match[3]}
>          )
> -        if [[ $_svnadmin_subcmd_usage == *REPOS_PATH* ]]; then
> +        if [[ $usage == *REPOS_PATH* ]]; then
>            args+=( ":path:_files -/" )
>          elif [[ $cmd = help ]]; then
>            args+=( "*:subcommand:_svnadmin_commands" )

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


^ permalink raw reply	[flat|nested] 4+ messages in thread

* PATCH: fixing _subversion
@ 2009-06-01 17:56 Akinori MUSHA
  2009-06-02  8:48 ` Peter Stephenson
  0 siblings, 1 reply; 4+ messages in thread
From: Akinori MUSHA @ 2009-06-01 17:56 UTC (permalink / raw)
  To: pws; +Cc: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

Hi,

[Peter, I am mailing you because zsh-workers@ does not seem to accept
my mail and cvs log showed that you have been working on the file in
question below.]

The compdef for svnadmin has a typo that prevents REPOS_PATH
completion from working.  Apply the following patch to fix it.

Index: Completion/Unix/Command/_subversion
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_subversion,v
retrieving revision 1.27
diff -u -r1.27 _subversion
--- Completion/Unix/Command/_subversion	22 May 2009 15:48:32 -0000	1.27
+++ Completion/Unix/Command/_subversion	31 May 2009 06:35:24 -0000
@@ -150,7 +150,7 @@
         args=(
           ${=${${${(M)${(f)"$(LC_ALL=C _call_program options svnadmin help $cmd)"#(*Valid options:|(#e))}:#* :*}%% #:*}/ (arg|ARG)/:arg:}/(#b)-([[:alpha:]]) \[--([a-z-]##)\](:arg:)#/(--$match[2])-$match[1]$match[3] (-$match[1])--$match[2]$match[3]}
         )
-        if [[ $_svnadmin_subcmd_usage == *REPOS_PATH* ]]; then
+        if [[ $usage == *REPOS_PATH* ]]; then
           args+=( ":path:_files -/" )
         elif [[ $cmd = help ]]; then
           args+=( "*:subcommand:_svnadmin_commands" )


Regards,

--
Akinori MUSHA / http://akinori.org/

[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* PATCH: fixing _subversion
@ 2009-06-01 17:26 Akinori MUSHA
  0 siblings, 0 replies; 4+ messages in thread
From: Akinori MUSHA @ 2009-06-01 17:26 UTC (permalink / raw)
  To: zsh-workers

Hi,

The compdef for svnadmin has a typo that prevents REPOS_PATH
completion from working.  Apply the following patch to fix it.

Index: Completion/Unix/Command/_subversion
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_subversion,v
retrieving revision 1.27
diff -u -r1.27 _subversion
--- Completion/Unix/Command/_subversion	22 May 2009 15:48:32 -0000	1.27
+++ Completion/Unix/Command/_subversion	31 May 2009 06:35:24 -0000
@@ -150,7 +150,7 @@
         args=(
           ${=${${${(M)${(f)"$(LC_ALL=C _call_program options svnadmin help $cmd)"#(*Valid options:|(#e))}:#* :*}%% #:*}/ (arg|ARG)/:arg:}/(#b)-([[:alpha:]]) \[--([a-z-]##)\](:arg:)#/(--$match[2])-$match[1]$match[3] (-$match[1])--$match[2]$match[3]}
         )
-        if [[ $_svnadmin_subcmd_usage == *REPOS_PATH* ]]; then
+        if [[ $usage == *REPOS_PATH* ]]; then
           args+=( ":path:_files -/" )
         elif [[ $cmd = help ]]; then
           args+=( "*:subcommand:_svnadmin_commands" )


Regards,

--
Akinori MUSHA / http://akinori.org/


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-06-07 11:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-31 15:04 PATCH: fixing _subversion Akinori MUSHA
2009-06-01 17:26 Akinori MUSHA
2009-06-01 17:56 Akinori MUSHA
2009-06-02  8:48 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).