From: Frank Terbeck <ft@bewatermyfriend.org>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: vcs_info: '%' in payloads not escaped
Date: Thu, 05 Jan 2017 17:27:06 +0100 [thread overview]
Message-ID: <871swhqxph.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20170105160730.GA21106@fujitsu.shahaf.local2> (Daniel Shahaf's message of "Thu, 5 Jan 2017 16:07:30 +0000")
Hey Daniel!
Daniel Shahaf wrote:
[...]
> How about the following?
> else
> git_applied_s=""
> fi
> + git_applied_s=${git_applied_s//'%'/%%}
> else
[...]
> git_patches_unapplied=${#git_patches_unapplied}
> + git_patches_unapplied=${git_patches_unapplied//'%'/%%}
> else
I honestly don't know. Isn't this like kind-of-predictable behavior
versus a — potentially — a lot of special cases? I don't think that it's
possible to get this right in the general case. It's in-band data that
is indistinguishable from data that is interpreted by something that
interprets zsh's prompt language.
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
next prev parent reply other threads:[~2017-01-05 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 15:05 Daniel Shahaf
2016-12-27 15:13 ` Daniel Shahaf
2017-01-05 16:07 ` Daniel Shahaf
2017-01-05 16:27 ` Frank Terbeck [this message]
2017-01-06 2:21 ` Daniel Shahaf
2017-01-06 10:41 ` Frank Terbeck
2017-01-06 16:40 ` Daniel Shahaf
2017-01-06 17:27 ` Bart Schaefer
2017-01-23 11:04 ` Daniel Shahaf
2017-01-23 18:54 ` Frank Terbeck
2017-02-05 8:28 ` [PATCH] vcs_info: Escape '%' signs in payloads Daniel Shahaf
2017-02-07 8:57 ` Daniel Shahaf
2017-01-06 15:55 ` vcs_info: '%' in payloads not escaped Bart Schaefer
2017-01-06 16:49 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871swhqxph.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).