zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: vcs_info: '%' in payloads not escaped
Date: Fri, 6 Jan 2017 16:49:30 +0000	[thread overview]
Message-ID: <20170106164930.GC4948@fujitsu.shahaf.local2> (raw)
In-Reply-To: <170106075524.ZM7127@torch.brasslantern.com>

Bart Schaefer wrote on Fri, Jan 06, 2017 at 07:55:24 -0800:
> On Jan 5,  4:07pm, Daniel Shahaf wrote:
> }
> } How about the following?
> } 
> } [[[
> } @@ -131,12 +131,14 @@ VCS_INFO_git_handle_patches () {
> }          else
> }              git_applied_s=""
> }          fi
> } +        git_applied_s=${git_applied_s//'%'/%%}
> }      else
> }          git_applied_s=${hook_com[applied-string]}
> }      fi
> 
> Shouldn't that + go above the "else"?  No point in substituting on
> git_applied_s when it has just been set to "" ?

I was just future-proofing the code against potential future changes in
the 'else' branch.  See users/22290 ;-)


      reply	other threads:[~2017-01-06 16:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-27 15:05 Daniel Shahaf
2016-12-27 15:13 ` Daniel Shahaf
2017-01-05 16:07 ` Daniel Shahaf
2017-01-05 16:27   ` Frank Terbeck
2017-01-06  2:21     ` Daniel Shahaf
2017-01-06 10:41       ` Frank Terbeck
2017-01-06 16:40         ` Daniel Shahaf
2017-01-06 17:27           ` Bart Schaefer
2017-01-23 11:04             ` Daniel Shahaf
2017-01-23 18:54               ` Frank Terbeck
2017-02-05  8:28                 ` [PATCH] vcs_info: Escape '%' signs in payloads Daniel Shahaf
2017-02-07  8:57                   ` Daniel Shahaf
2017-01-06 15:55   ` vcs_info: '%' in payloads not escaped Bart Schaefer
2017-01-06 16:49     ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106164930.GC4948@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).