* [PATCH] Fix scons '--jobs' and '--question' completions
@ 2023-08-18 8:15 Shohei YOSHIDA
2023-08-21 8:21 ` Jun T
0 siblings, 1 reply; 2+ messages in thread
From: Shohei YOSHIDA @ 2023-08-18 8:15 UTC (permalink / raw)
To: zsh-workers; +Cc: Shohei YOSHIDA
They are long options so they must start with '--'.
And This fixes optspec of '-j'/'--jobs' because they always take
a number argument.
Reference
- https://scons.org/doc/production/HTML/scons-man.html
---
Completion/Unix/Command/_scons | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Completion/Unix/Command/_scons b/Completion/Unix/Command/_scons
index 77fe6dfb0..0e40432ab 100644
--- a/Completion/Unix/Command/_scons
+++ b/Completion/Unix/Command/_scons
@@ -24,14 +24,14 @@ _arguments -s -S \
'(--implicit-cache --implicit-deps-changed)--implicit-deps-changed[rescan dependencies]' \
'(--implicit-cache --implicit-deps-unchanged)--implicit-deps-unchanged[ignore changes to scanned dependencies]' \
'--interactive[start interactive mode]' \
- '(-j --jobs)-'{j,jobs=}'[specify no of jobs to run in parallel]' \
+ '(-j --jobs)-'{j,-jobs=}'[specify no of jobs to run in parallel]:' \
'(-k --keep-going)-'{k,-keep-going}'[continue after an error]' \
'--max-drift=[set the maximum clock drift]:drift (seconds)' \
'--md5-chunksize=[set chunksize for MD5 signature computation]:size (kB)' \
'(-n --just-print --dry-run --recon)-'{n,-just-print,-dry-run,-recon}"[print commands but don't run them]" \
"--no-site-dir[don't use the usual site_scons directory]" \
'--profile=[profile scons]:output file:_files' \
- '(-q --question)-'{q,question}'[query whether up-to-date]' \
+ '(-q --question)-'{q,-question}'[query whether up-to-date]' \
'-Q[suppress progress messages]' \
'--random[build dependencies in random order]' \
'(-s --silent --quiet)-'{s,-silent,-quiet}"[don't print commands]" \
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix scons '--jobs' and '--question' completions
2023-08-18 8:15 [PATCH] Fix scons '--jobs' and '--question' completions Shohei YOSHIDA
@ 2023-08-21 8:21 ` Jun T
0 siblings, 0 replies; 2+ messages in thread
From: Jun T @ 2023-08-21 8:21 UTC (permalink / raw)
To: zsh-workers
> 2023/08/18 17:15, Shohei YOSHIDA <syohex@gmail.com> wrote:
>
> And This fixes optspec of '-j'/'--jobs' because they always take
> a number argument.
(snip)
> - '(-j --jobs)-'{j,jobs=}'[specify no of jobs to run in parallel]' \
> + '(-j --jobs)-'{j,-jobs=}'[specify no of jobs to run in parallel]:' \
Thanks.
I think it would be better to add also a message, like
'(-j --jobs)-'{j,-jobs=}'[specify no of jobs to run in parallel]:number of jobs' \
I will push with this modification.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-21 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-18 8:15 [PATCH] Fix scons '--jobs' and '--question' completions Shohei YOSHIDA
2023-08-21 8:21 ` Jun T
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).