From: "Lawrence Velázquez" <firstname.lastname@example.org>
Cc: "Marlon Richert" <email@example.com>
Subject: Re: [PATCH] Make _expand_alias more usable as a completer
Date: Sun, 18 Jul 2021 19:34:02 -0400 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On Sun, Jun 20, 2021, at 6:24 PM, Marlon Richert wrote:
> On Mon, Jun 21, 2021 at 12:08 AM Mikael Magnusson <email@example.com> wrote:
> > On 6/20/21, Lawrence Velázquez <firstname.lastname@example.org> wrote:
> > > On Thu, Jun 3, 2021, at 5:42 PM, Marlon Richert wrote:
> > >> On Thu, Jun 3, 2021 at 2:24 AM Oliver Kiddle <email@example.com> wrote:
> > >>
> > >> > I also wonder if this would be better done from within _command_names
> > >> > directly but I'm not sure.
> > >>
> > >> Actually, I feel like it could instead be added to the _expand
> > >> completer. Would that be a better idea than what I presented in this
> > >> patch?
> > >
> > > Anyone have answers to Marlon's questions?
> > If it helps, I disagree with conflating _expand_alias (expanding
> > aliases) and _expand (filename expansion).
> _expand already handles a lot more than just "filename expansion"
> (which it actually does not handle at all). A quick test going through
> all forms of expansion listed at
> https://zsh.sourceforge.io/Doc/Release/Expansion.html shows that
> _expand currently handles all of the following:
> * parameter expansion
> * command substitution
> * arithmetic expansion
> * brace expansion
> * filename generation
> (but not history expansion, alias expansion, process substitution or
> filename expansion).
> Since alias expansion is in fact listed at
> https://zsh.sourceforge.io/Doc/Release/Expansion.html, I don't think
> it would be too weird to add it to the _expand completer.
Any other feedback on 48946?
next prev parent reply other threads:[~2021-07-18 23:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 21:59 Marlon Richert
2021-06-02 23:23 ` Oliver Kiddle
2021-06-03 21:42 ` Marlon Richert
2021-06-20 19:49 ` Lawrence Velázquez
2021-06-20 21:08 ` Mikael Magnusson
2021-06-20 22:24 ` Marlon Richert
2021-07-18 23:34 ` Lawrence Velázquez [this message]
2021-07-28 3:23 ` Bart Schaefer
2021-08-01 18:50 ` [PATCH] Make _expand handle aliases (was Re: [PATCH] Make _expand_alias more usable as a completer) Marlon Richert
2022-03-31 22:35 ` Lawrence Velázquez
2022-04-01 0:37 ` Bart Schaefer
2022-05-06 5:57 ` Marlon Richert
2022-05-07 20:39 ` Bart Schaefer
2022-05-11 7:32 ` Marlon Richert
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).