zsh-workers
 help / color / mirror / code / Atom feed
* A little cleanup
@ 1995-07-03  4:41 Zefram
  1995-07-05  6:21 ` Wayne Davison
  0 siblings, 1 reply; 2+ messages in thread
From: Zefram @ 1995-07-03  4:41 UTC (permalink / raw)
  To: Z Shell workers mailing list

-----BEGIN PGP SIGNED MESSAGE-----

It seems that ZLE_NAMEDBUFFER isn't actually used anywhere.  This minor
cleanup doesn't seem to break anything...

      *** Src/zle.h.old	Mon Jul  3 05:18:30 1995
      --- Src/zle.h	Mon Jul  3 05:28:36 1995
      ***************
      *** 205,217 ****
        #define ZLE_YANK     	 8
        #define ZLE_LINEMOVE 	 16
        #define ZLE_ARG      	 32
      ! #define ZLE_NAMEDBUFFER 128
      ! #define ZLE_KILL        (64|ZLE_NAMEDBUFFER)
        #define ZLE_HISTSEARCH  256
        #define ZLE_NEGARG      512
        #define ZLE_INSERT     1024
        #define ZLE_DELETE     2048
      - #define ZLE_DIGIT      4096
        
        typedef struct key *Key;
        
      --- 205,216 ----
        #define ZLE_YANK     	 8
        #define ZLE_LINEMOVE 	 16
        #define ZLE_ARG      	 32
      ! #define ZLE_DIGIT        64
      ! #define ZLE_KILL        128
        #define ZLE_HISTSEARCH  256
        #define ZLE_NEGARG      512
        #define ZLE_INSERT     1024
        #define ZLE_DELETE     2048
        
        typedef struct key *Key;
        
      *** Src/zle_bindings.c.old	Mon Jul  3 05:17:27 1995
      --- Src/zle_bindings.c	Mon Jul  3 05:34:27 1995
      ***************
      *** 169,175 ****
            {"vi-yank", viyank, 0},
            {"vi-yank-eol", viyankeol, 0},
            {"which-command", processcmd, 0},
      !     {"yank", yank, ZLE_YANK | ZLE_NAMEDBUFFER},
            {"yank-pop", yankpop, ZLE_YANK},
            {"emacs-backward-word", emacsbackwardword, ZLE_MOVEMENT},
            {"emacs-forward-word", emacsforwardword, ZLE_MOVEMENT},
      --- 169,175 ----
            {"vi-yank", viyank, 0},
            {"vi-yank-eol", viyankeol, 0},
            {"which-command", processcmd, 0},
      !     {"yank", yank, ZLE_YANK},
            {"yank-pop", yankpop, ZLE_YANK},
            {"emacs-backward-word", emacsbackwardword, ZLE_MOVEMENT},
            {"emacs-forward-word", emacsforwardword, ZLE_MOVEMENT},

 -zefram

-----BEGIN PGP SIGNATURE-----
Version: 2.6.i

iQBVAgUBL/d0lWWJ8JfKi+e9AQGQtgIAjwncrZp817+Sy/1+R+bk8Z0W0SRayXQh
XYNxhCzckzxYQ3n/p/FlxSKrkwvbFJposefcp1qqtzBC9CZugt3wUw==
=WVre
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: A little cleanup
  1995-07-03  4:41 A little cleanup Zefram
@ 1995-07-05  6:21 ` Wayne Davison
  0 siblings, 0 replies; 2+ messages in thread
From: Wayne Davison @ 1995-07-05  6:21 UTC (permalink / raw)
  To: Zefram; +Cc: zsh-workers

> It seems that ZLE_NAMEDBUFFER isn't actually used anywhere.  This minor
> cleanup doesn't seem to break anything...

And actually fixed the bug I reported when yanking things (where
zsh keeps using the same kill buffer after a yank as it was using
before).  With this cleaned up, my patch to zle_utils.c (that has
not yet been included as of beta 10) is no longer needed.  The
change was on line 113:

    else if (!(lastcmd & ZLE_KILL)) {

changed to:

    else if ((lastcmd & ZLE_KILL) != ZLE_KILL) {

It was required because ZLE_NAMEDBUFFER had ZLE_KILL in it, but
with the cleanup only kill commands now have ZLE_KILL set -- a
good thing.

..wayne..


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1995-07-05  6:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1995-07-03  4:41 A little cleanup Zefram
1995-07-05  6:21 ` Wayne Davison

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).