From: Tim Eliseo <tre-zsh@crushedhat.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Add option like tcsh's dextract
Date: Wed, 9 Aug 2023 16:27:00 -0700 [thread overview]
Message-ID: <95fe091c-b262-e7b3-0358-4648179e32d8@crushedhat.com> (raw)
In-Reply-To: <CAH+w=7bjSfEjWuZVzRReC9tQLp+4eg_BaAhGzrjb1BpAtXwkhQ@mail.gmail.com>
On 2023-08-09 10:25:39, Bart Schaefer wrote:
> On Wed, Aug 9, 2023 at 9:25 AM Mikael Magnusson <mikachu@gmail.com> wrote:
>> On 8/9/23, Tim Eliseo <tre-zsh@crushedhat.com> wrote:
>>> Do you have any remaining questions or concerns that prevent this patch
>>> from being merged?
>> The manpage entry says:
>> This option makes tt(pushd) using `tt(PLUS())' or `tt(-)' behave
>> like tt(cd) with tt(AUTO_PUSHD) set.
> Similar minor nit:
>
> +A push using `tt(PLUS())' or `tt(-)' will reorder by moving the specified
>
> I realize other parts of the manual are not consistent about this, but
> passive voice should be avoided, i.e., say "reorders by moving" rather
> than "will reorder".
Okay, will fix the passive voice, or maybe it’s present instead of
future tense. Hard to keep track.
> Aside to zsh-workers in general: good grief, the bf() yodl macro is
> really inconsistently applied. So much so that I didn't even realize
> it existed until I read this patch. I can think of at least a few
> uses of em() that would probably be better as bf().
I used bf() because I saw it used for other external command names. Is
that correct?
Tim
next prev parent reply other threads:[~2023-08-09 23:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 9:54 Tim Eliseo
2023-07-18 15:17 ` Mikael Magnusson
2023-08-04 16:47 ` Tim Eliseo
2023-08-04 16:58 ` Mikael Magnusson
[not found] ` <ee258794-761e-8f48-01d2-f0db6d8b6dc7@crushedhat.com>
2023-08-04 18:08 ` Mikael Magnusson
2023-08-05 23:48 ` Bart Schaefer
2023-08-08 22:13 ` Tim Eliseo
2023-08-09 8:50 ` Peter Stephenson
2023-08-09 13:16 ` Mikael Magnusson
2023-08-09 14:19 ` Tim Eliseo
2023-08-09 16:24 ` Mikael Magnusson
2023-08-09 17:25 ` Bart Schaefer
2023-08-09 23:27 ` Tim Eliseo [this message]
2023-08-12 3:42 ` Bart Schaefer
2023-08-09 22:49 ` Tim Eliseo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95fe091c-b262-e7b3-0358-4648179e32d8@crushedhat.com \
--to=tre-zsh@crushedhat.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).