zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Tim Eliseo <tre-zsh@crushedhat.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Add option like tcsh's dextract
Date: Wed, 9 Aug 2023 18:24:53 +0200	[thread overview]
Message-ID: <CAHYJk3TxnrfCneGS6608d4O4dhZDRosVmosQGLEtwERL6j6MpQ@mail.gmail.com> (raw)
In-Reply-To: <8ac7f49d-3cb5-52b5-61ff-d5beff1bbb8a@crushedhat.com>

On 8/9/23, Tim Eliseo <tre-zsh@crushedhat.com> wrote:
> On 2023-08-09 06:16:54, Mikael Magnusson wrote:
>>
>> Every time I've asked for more details you ignored me, which as I
>> pointed out earlier is not a good approach. I thought I very clearly
>> asked you in my first mail why just cd + autopushd was not enough, and
>> then you wouldn't even reply to my second request to answer my
>> question which surely put others off as well.
>>
>> To summarize, when you send a mail with a patch, explain the patch and
>> why it's needed in the mail; if someone asks for clarifications or
>> seems to misunderstand you, rather than assume that they can't read,
>> assume that you were unclear, it is the safer assumption.
>>
> I’ll agree that we had a misunderstanding, and will keep this in mind
> for the future.
>
> Do you have any remaining questions or concerns that prevent this patch
> from being merged?

The manpage entry says:
  This option makes tt(pushd) using `tt(PLUS())' or `tt(-)' behave
like tt(cd) with tt(AUTO_PUSHD) set.

This is true as I understand it, but it somewhat implies that pushd
without +/- acts differently from cd, so perhaps it should just say
"This option makes pushd behave like cd with AUTO_PUSHD set.", which
is also true but harder to misinterpret. (I wouldn't oppose keeping it
as it is, it's just something that tripped me up while reading it.)

Another thought I had was that perhaps with this option existing, the
behavior between cd and pushd need not be different at all anymore,
but maybe someone prefers being able to extract with cd and roll with
pushd, so probably not worth messing with that. It would also be
unclear which way the default should be in that case...

-- 
Mikael Magnusson


  reply	other threads:[~2023-08-09 16:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18  9:54 Tim Eliseo
2023-07-18 15:17 ` Mikael Magnusson
2023-08-04 16:47 ` Tim Eliseo
2023-08-04 16:58   ` Mikael Magnusson
     [not found]     ` <ee258794-761e-8f48-01d2-f0db6d8b6dc7@crushedhat.com>
2023-08-04 18:08       ` Mikael Magnusson
2023-08-05 23:48   ` Bart Schaefer
2023-08-08 22:13     ` Tim Eliseo
2023-08-09  8:50       ` Peter Stephenson
2023-08-09 13:16       ` Mikael Magnusson
2023-08-09 14:19         ` Tim Eliseo
2023-08-09 16:24           ` Mikael Magnusson [this message]
2023-08-09 17:25             ` Bart Schaefer
2023-08-09 23:27               ` Tim Eliseo
2023-08-12  3:42                 ` Bart Schaefer
2023-08-09 22:49             ` Tim Eliseo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHYJk3TxnrfCneGS6608d4O4dhZDRosVmosQGLEtwERL6j6MpQ@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=tre-zsh@crushedhat.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).