UGLY CRASHES UNDER ZSH 2.6 BETA 12

UGLY CRASHES UNDER ZSH 2.6 BETA 12

[Eskandar Ensafi]

Hello,


I just experienced the following bug (zsh 2.6 beta 12 on NEXTSTEP 3.3):

marathon(1)% bvi out.dvi                                                    (~)
zsh: correct `bvi' to `vi' [nyae]? n
zsh: command not found: bvi
marathon(2)% !!                                                             (~)
Connection closed.

I then tried the same thing in a subshell:

marathon(1)% zsh                                                            (~)
marathon(2)% bvi out.dvi                                                    (~)
zsh: correct `bvi' to `vi' [nyae]? n
zsh: command not found: bvi
marathon(3)% !!                                                             (~)
zsh: 527 bus error  zsh

[Process terminated on signal 10]

Any idea what coudl be causing this?

Thanks!


- Eskandar

------------------------------------------------------------------------------
Eskandar Ensafi                              Object-Oriented Software Engineer
University of California, Los Angeles                                         
Department of Biomathematics              esky@cs.ucla.edu (ASCII, MIME, NeXT)
School of Medicine                  http://www.cs.ucla.edu/csd-lanai/fweb/esky
------------------------------------------------------------------------------

Re: UGLY CRASHES UNDER ZSH 2.6 BETA 12

[Zefram]

>I just experienced the following bug (zsh 2.6 beta 12 on NEXTSTEP 3.3):
>
>marathon(1)% bvi out.dvi                                                    (~)
>zsh: correct `bvi' to `vi' [nyae]? n
>zsh: command not found: bvi
>marathon(2)% !!                                                             (~)
>Connection closed.

I can't reproduce this on SunOS 4.1.4, 2.6 beta 12 and beta 13.

-zefram

Re: UGLY CRASHES UNDER ZSH 2.6 BETA 12

[Eskandar Ensafi]

Hello,

On Wed, 28 Feb 1996 12:24:43 GMT, Zefram wrote:
> >I just experienced the following bug (zsh 2.6 beta 12 on NEXTSTEP 3.3):
> >[... details omitted ...]
>
> I can't reproduce this on SunOS 4.1.4, 2.6 beta 12 and beta 13.
> 


Perhaps this will give someone a clue as to where the problem occurred:

(gdb) run
Starting program: /usr/local/bin/zsh 
marathon% bvi foo
zsh: correct `bvi' to `vi' [nyae]? n
zsh: command not found: bvi
marathon% !!
Program generated(1): Memory access exception on address 0x10 (protection failure).
0x164c2 in clearalstack ()
(gdb) where
#0  0x164c2 in clearalstack ()
#1  0x1b1ba in lexrestore ()
#2  0x31cea in putpromptchar ()
#3  0x31b30 in putprompt ()
#4  0x29f96 in spckword ()
#5  0x1c408 in exalias ()
#6  0x1b21a in yylex ()
#7  0x21830 in parse_event ()
#8  0x17d90 in loop ()
#9  0x17cb4 in main ()
(gdb) quit


Then we can find out why it didn't occur under SunOS, and if can potentially
occur under other operating sytems.

My time is very limited -- can anyone who has a little extra time on their
hands *please* look into this?

- Eskandar

------------------------------------------------------------------------------
Eskandar Ensafi                              Object-Oriented Software Engineer
University of California, Los Angeles                                         
Department of Biomathematics              esky@cs.ucla.edu (ASCII, MIME, NeXT)
School of Medicine                  http://www.cs.ucla.edu/csd-lanai/fweb/esky
------------------------------------------------------------------------------

Re: UGLY CRASHES UNDER ZSH 2.6 BETA 12

[Peter Stephenson]

esky@cs.ucla.edu wrote:
> Starting program: /usr/local/bin/zsh 
> marathon% bvi foo
> zsh: correct `bvi' to `vi' [nyae]? n
> zsh: command not found: bvi
> marathon% !!
> Program generated(1): Memory access exception on address 0x10 (protection fai
> lure).
> 0x164c2 in clearalstack ()

I can't reproduce this either for some reason, but my guess is that
the alias stack has got a NULL on it, which signifies history
expansion, and the lexrestore() is assuming it's an alias and trying
to dereference it.  Have a go at this (should be completely safe to
give to the kids at home):

*** Src/hist.c~	Mon Feb 19 10:09:38 1996
--- Src/hist.c	Fri Mar  1 14:31:05 1996
***************
*** 440,447 ****
      Alias ix;
  
      while (alstackind) {
! 	ix = alstack[--alstackind];
! 	ix->inuse = 0;
      }
  }
  
--- 440,447 ----
      Alias ix;
  
      while (alstackind) {
! 	if ((ix = alstack[--alstackind]))
! 	  ix->inuse = 0;
      }
  }
  

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77330
Deutches Electronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.

New hist.c patch (Was: Re: UGLY CRASHES UNDER ZSH 2.6 BETA 12)

[Eskandar Ensafi]

Hello,

On Fri, 01 Mar 1996 14:36:42 +0100, Peter Stephenson wrote:
[original bug report omitted]
> I can't reproduce this either for some reason, but my guess is that
> the alias stack has got a NULL on it, which signifies history
> expansion, and the lexrestore() is assuming it's an alias and trying
> to dereference it.  Have a go at this (should be completely safe to
> give to the kids at home):


Thanks!  It worked.  Here's Peter's patch again:


==============================================================================
*** Src/hist.c~	Mon Feb 19 10:09:38 1996
--- Src/hist.c	Fri Mar  1 14:31:05 1996
***************
*** 440,447 ****
      Alias ix;
  
      while (alstackind) {
! 	ix = alstack[--alstackind];
! 	ix->inuse = 0;
      }
  }
  
--- 440,447 ----
      Alias ix;
  
      while (alstackind) {
! 	if ((ix = alstack[--alstackind]))
! 	  ix->inuse = 0;
      }
  }
==============================================================================

Later,

- Eskandar

------------------------------------------------------------------------------
Eskandar Ensafi                              Object-Oriented Software Engineer
University of California, Los Angeles                                         
Department of Biomathematics              esky@cs.ucla.edu (ASCII, MIME, NeXT)
School of Medicine                  http://www.cs.ucla.edu/csd-lanai/fweb/esky
------------------------------------------------------------------------------

Re: UGLY CRASHES UNDER ZSH 2.6 BETA 12

[Zoltan Hidvegi]

[-- Attachment #1: Type: application/pgp, Size: 4232 bytes --]