From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Zoltan Hidvegi <hzoli@ny.frontiercomm.net>,
zsh-workers@math.gatech.edu (Zsh hacking and development)
Subject: Re: test patches
Date: Sat, 10 May 1997 10:09:20 -0700 [thread overview]
Message-ID: <970510100920.ZM9250@candle.brasslantern.com> (raw)
In-Reply-To: <199705090742.DAA09847@hzoli.home>
Some remarks on the 3.0.3-test5 patch:
The FAQ diff isn't included. No biggie, but people should be aware that
they'll still have last December's FAQ if all they do is patch.
I'm curious: What's the point of removing functions like setcurjob()
and inlining their code in the function that calls them? We're surely
not all that worried about function call overhead, and it seems to me
that it makes future changes more difficult (or at least potentially
larger diffs). Even if the function is only called in one place, it's
preferable to work towards small, single-purpose functions, isn't it?
(It also makes stack traces without full debugging symbols easier to
interpret.) [setcurjob happened a while ago, but I just noticed it.]
There still doesn't appear to be a test in init.c for the case where
the system supports TIOCGWINSZ but the rows and columns value in the
shttyinfo.winsize structure are both zero. In that case we ought to
be using the row and column sizes from the termcap or terminfo entry?
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.nbn.com/people/lantern
next prev parent reply other threads:[~1997-05-10 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-05-09 7:42 Zoltan Hidvegi
1997-05-09 8:04 ` Hrvoje Niksic
1997-05-09 17:50 ` Zoltan T. Hidvegi
1997-05-09 8:49 ` Bart Schaefer
1997-05-09 14:00 ` Zefram
1997-05-09 18:09 ` Zoltan T. Hidvegi
1997-05-09 20:40 ` Zefram
1997-05-09 21:04 ` Zoltan T. Hidvegi
1997-05-10 17:09 ` Bart Schaefer [this message]
1997-05-10 17:48 ` Zoltan Hidvegi
1997-05-10 19:12 ` Bart Schaefer
1997-05-11 4:57 ` Zoltan Hidvegi
1997-05-12 12:41 ` Andrej Borsenkow
1997-05-12 17:49 ` Zefram
1997-05-13 5:46 ` Andrej Borsenkow
1997-05-13 16:08 ` Zefram
1997-05-13 18:53 ` Zoltan T. Hidvegi
1997-05-11 6:19 Zoltan Hidvegi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970510100920.ZM9250@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=hzoli@ny.frontiercomm.net \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).