From: dana <dana@dana.is>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: P01privileged fails on CentOS/Fedora (a simple permission issue)
Date: Fri, 13 Mar 2020 09:19:37 -0500 [thread overview]
Message-ID: <A8F64239-2976-4D1E-8427-5818F28C0FAE@dana.is> (raw)
In-Reply-To: <E696D283-AFC7-4236-967B-E9E504AA253D@kba.biglobe.ne.jp>
On 13 Mar 2020, at 05:16, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
> Personally I feel it's simpler to use relative path, but have no objection
> to using UID of ZTST_tesdir.
>
> # If you don't like hard-coding the directory name we can pass it from
> # Test/Makefile.in, via a variable like ZTST_moddir, to ztst.zsh (line 38)
> # and use it in P01privileged.ztst.
You're definitely right that it's simpler that way.
I'm less worried about the name of the directory than about its location,
which i'm not sure is in the test file's purview. If it's alright for it to
make the assumption that the module directory is under $ZTST_dir then we could
simply use ${module_path#$ZTST_dir/}. I would be OK with that compromise.
Though — and i'm absolutely rationalising after the fact now — using the UID
of the test directory will also take care of the case where the repo itself
has been cloned with umask 027 or 077 (unless it's owned by root...).
Does that justify the complexity? I don't know
dana
next prev parent reply other threads:[~2020-03-13 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 2:59 Jun T
2020-03-10 17:26 ` Jun. T
2020-03-11 20:06 ` dana
2020-03-11 20:26 ` Bart Schaefer
2020-03-12 18:11 ` dana
2020-03-13 10:16 ` Jun T
2020-03-13 14:19 ` dana [this message]
2020-03-17 5:34 ` Jun T
2020-04-01 22:35 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A8F64239-2976-4D1E-8427-5818F28C0FAE@dana.is \
--to=dana@dana.is \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).