[PATCH] git log's "branch" argument is optional

[PATCH] git log's "branch" argument is optional

[Holger Weiss]

This patch fixes the problem that "git log f<Tab>" currently doesn't
complete file names.
---
 Completion/Unix/Command/_git |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index cb06d57..ccf29a4 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -1871,7 +1871,7 @@ _git-log () {
   case $state in
     (files)
       _arguments -S \
-        ':branch:__git_commit_ranges2' \
+        '::branch:__git_commit_ranges2' \
         '*:index file:__git_cached_files' && ret=0
       ;;
   esac
-- 
Holger

Re: [PATCH] git log's "branch" argument is optional

[Simon Ruderich]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

On Sun, Jun 06, 2010 at 01:40:12PM +0200, Holger Weiss wrote:
> This patch fixes the problem that "git log f<Tab>" currently doesn't
> complete file names.
>
> [snip]

Could this patch please get applied? It works fine for me and
fixes the mentioned problem.

Thanks,
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] git log's "branch" argument is optional

[Wayne Davison]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

On Sat, Jul 24, 2010 at 3:36 AM, Simon Ruderich <simon@ruderich.org> wrote:

> Could this patch please get applied? It works fine for me and
> fixes the mentioned problem.
>

I've committed the change.  I hadn't noticed the problem because I use an
alias lo='git log --patience', and that apparently by-passes the branch
completion.  Indeed, it is impossible to complete a branch name after an
option, so we'll need to look into fixing that next.

..wayne..