From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: Should we "fix" this declaration?
Date: Mon, 11 Sep 2023 16:28:06 +0900 [thread overview]
Message-ID: <BE8BC0C3-F822-489B-81D8-C2675B0F1186@kba.biglobe.ne.jp> (raw)
In-Reply-To: <CAH+w=7ZzFmeiu+njYY6Kojq0549Vp-Dr3tD=JkjT3KBC1ZmAEw@mail.gmail.com>
> 2023/09/11 7:00, Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> have_edits = 0;
> Histent he;
>
> That's from users/29175, but we've previously followed the old C
> format that declarations have to be at the start of a block.
I personally think we don't need to "fix" this.
The current zsh source already uses 'inline' function (new in C99, I think)
in hashtable.c. This is added by commit 6f6363d (Jul. 28, 2020). If I try
to build zsh on macOS (Apple clang 10.0) with CFLAGS='-std=c89' then it
first fails due to this inline function (may also fail on other files).
On Ubuntu 22.04 (gcc-11.4) CFLAGS='-std=c89' seems to give lots more errors.
I have no idea what kind of old compilers are still in use, but even if
they are not 100% compatible with C99 (especially some library functions),
I think they support '// comment' and 'mixed declarations and code'.
prev parent reply other threads:[~2023-09-11 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 22:00 Bart Schaefer
2023-09-11 7:28 ` Jun T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE8BC0C3-F822-489B-81D8-C2675B0F1186@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).