From: "Paul" <GammaFunction@vivaldi.net>
To: "Roman Perepelitsa" <roman.perepelitsa@gmail.com>,
"Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: [BUG]: zle-line-pre-redraw breaks vi-repeat-change
Date: Tue, 26 Jan 2021 14:55:09 -0600 [thread overview]
Message-ID: <C8TE0S473FV2.14B73I9JO6465@kbvv> (raw)
In-Reply-To: <CAN=4vMqPA1WAt6_Kj99_PGH+EvOpcK5So3bON5sjBzzmeikeXg@mail.gmail.com>
On Wed Dec 16, 2020 at 2:33 AM CST, Roman Perepelitsa wrote:
> On Wed, Oct 7, 2020 at 2:49 PM Roman Perepelitsa
> <roman.perepelitsa@gmail.com> wrote:
> >
> > If zle-line-pre-redraw is defined, vi-repeat-change behaves as if the
> > numeric argument was always 1.
> >
> > To reproduce from `zsh -f`:
> >
> > % function zle-line-pre-redraw() {}
> > % zle -N zle-line-pre-redraw
> > % bindkey -v
> > % 123456<ESC><2X><.>
> >
> > The last line in more detail:
> >
> > - "123456" is self-insert
> > - ESC is vi-cmd-mode
> > - "2X" is vi-backward-delete-char with NUMERIC = 2
> > - "." is vi-repeat-change
> >
> > Expected: BUFFER contains "16".
> >
> > Actual: BUFFER contains "126".
> >
> > The actual behavior is unchanged if <.> is replaced with <3.>. The
> > expected BUFFER in this case is "6".
>
> GammaFunction@vivaldi.net (CC-ed) has sent
> https://github.com/zsh-users/zsh/pull/69 that fixes the two tests I've
> described above. Here's the patch from the PR.
>
> Roman.
Hey, I just want to bump this, I would like to see this merged soon.
The PR has a second commit which renames some identifiers to be more
consistent, feel free to ignore it.
next prev parent reply other threads:[~2021-01-26 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 12:49 Roman Perepelitsa
2020-10-07 13:25 ` Peter Stephenson
2020-10-07 14:49 ` Roman Perepelitsa
2020-12-16 8:33 ` Roman Perepelitsa
2021-01-26 20:55 ` Paul [this message]
2021-01-27 10:06 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8TE0S473FV2.14B73I9JO6465@kbvv \
--to=gammafunction@vivaldi.net \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).