From: Guilherme Salazar <gmesalazar@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org, Baptiste Daroussin <baptiste.daroussin@gmail.com>
Subject: Re: zsh make(1) completion on FreeBSD
Date: Wed, 12 Oct 2016 00:27:38 -0300 [thread overview]
Message-ID: <CA+Hmt2jYkzTZBohoF3MpZ8P+MXyLJWpfAi7Mc1NOfBj3W_Zjwg@mail.gmail.com> (raw)
In-Reply-To: <CA+Hmt2ixfYgbXduUgaqCQTFMWyT4BhCGp7A0XUwJJ++fJtxrkw@mail.gmail.com>
By the way, completely unrelated question: I noticed some
inconsistencies in the use of tabs/spaces for indentation; are there
conventions for that in the project? If so, are patches fixing it
welcome?
On Tue, Oct 11, 2016 at 10:14 PM, Guilherme Salazar
<gmesalazar@gmail.com> wrote:
>> That's precisely what the _pick_variant call at the top of the function
>> does, so you can just test $is_gnu instead. Note that the enclosing if
>> already inspects that variable.
>
> $is_gnu will still give unix (on FreeBSD) in case `which make` is just
> a symlink to /usr/local/bin/gmake.
>
>> In current master (before your patch), the 'call-command' style is
>> consulted only for GNU make but not for FreeBSD. Do you know if that's
>> intentional, perhaps (going by the style's docs) because the GNU make
>> invocation has side-effects while the BSD make invocation has none?
>
> I'd expect the -n option to avoid side effects. Perhaps the reason is
> that the BSD make infrastructure is a lot different than GNU's and a
> single Makefile may not carry enough information by itself to generate
> good completion?
next prev parent reply other threads:[~2016-10-12 3:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 2:56 Guilherme Salazar
2016-10-11 21:21 ` Daniel Shahaf
2016-10-11 23:27 ` Guilherme Salazar
2016-10-12 0:02 ` Daniel Shahaf
2016-10-12 0:24 ` Guilherme Salazar
2016-10-12 0:36 ` Daniel Shahaf
2016-10-12 1:14 ` Guilherme Salazar
2016-10-12 3:27 ` Guilherme Salazar [this message]
2016-10-13 10:08 ` Oliver Kiddle
2016-10-14 6:10 ` Daniel Shahaf
2016-10-16 16:34 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+Hmt2jYkzTZBohoF3MpZ8P+MXyLJWpfAi7Mc1NOfBj3W_Zjwg@mail.gmail.com \
--to=gmesalazar@gmail.com \
--cc=baptiste.daroussin@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).