zsh-workers
 help / color / mirror / code / Atom feed
From: Eric Freese <ericdfreese@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Remove zpty exit hook from forked processes
Date: Thu, 2 Feb 2017 10:38:55 -0700	[thread overview]
Message-ID: <CAAikoAJEi4WmE+A0FbtAEatfGc7gdw+YnLvxRRnsqVDQrKCRag@mail.gmail.com> (raw)
In-Reply-To: <CAAikoAJJumUO3mGce5ptEaRqKX+yN6JFd6QKiOsECeG9Bx5K8A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

Hey Bart,

First, thanks very much for setting up the workaround email addresses.
I was having a hell of a time sending this patch.

> If the only meaningful diff is this one ...
>
> } +     deletehookfunc("exit", ptyhook);
> }       clearjobtab(0);
>
> ... then there is no reason to move around all those static functions.
> Just mark the one to be declared in the autogenerated header file.

I wasn't aware of the significance of the `/**/` comment above certain
functions but it makes perfect sense now.

I'm not familiar with the etiquette around making changes to a patch
since I've mostly worked with GitHub and their pull requests for
submitting changes to open source projects.

Would it be most helpful for me to re-submit a modified patch, or do
you have everything you need from me to make the requested change?

Cheers,
Eric

  reply	other threads:[~2017-02-02 17:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 20:41 Eric Freese
2017-02-02  0:56 ` Bart Schaefer
2017-02-02  1:25   ` Eric Freese
2017-02-02 17:38     ` Eric Freese [this message]
2017-02-03  0:49       ` Bart Schaefer
  -- strict thread matches above, loose matches on Subject: below --
2017-02-01  6:12 Eric Freese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAikoAJEi4WmE+A0FbtAEatfGc7gdw+YnLvxRRnsqVDQrKCRag@mail.gmail.com \
    --to=ericdfreese@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).