From: Vin Shelton <acs@alumni.princeton.edu>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: can't set tty pgrp
Date: Thu, 19 Apr 2018 09:51:39 -0400 [thread overview]
Message-ID: <CACeGjnVjAjJVi1uWDGhn_5VLJRUEu80idjNOhspCfsE8EoJgkw@mail.gmail.com> (raw)
In-Reply-To: <20180419123339.3f897060@camnpupstephen.cam.scsc.local>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
Seems to work. Thanks. I think this is serious enough to merit a 5.5.2
release. Thoughts?
- Vin
On Thu, Apr 19, 2018 at 7:33 AM, Peter Stephenson <p.stephenson@samsung.com>
wrote:
> On Thu, 19 Apr 2018 06:57:40 -0400
> Vin Shelton <acs@alumni.princeton.edu> wrote:
> > The process group changes seem to have broken something:
> >
> >
> > : ~ Thu 19 6:52; vi
> > ^Z
> > zsh: suspended vi
> > : ~ Thu 19 6:52; fg
> > [1] + continued vi
> > zsh: can't set tty pgrp: no such process
>
> Yep, I remember thinking about this and forgetting to do anything...
>
> The following looks like it ought to be safe.
>
> diff --git a/Src/signals.c b/Src/signals.c
> index 2a6aa3f..6e12158 100644
> --- a/Src/signals.c
> +++ b/Src/signals.c
> @@ -537,7 +537,8 @@ wait_for_processes(void)
> #else
> update_process(pn, status);
> #endif
> - if (pn->pid == jn->gleader) {
> + if (WIFEXITED(status) &&
> + pn->pid == jn->gleader) {
> jn->gleader = 0;
> if (!(jn->stat & STAT_NOSTTY)) {
> /*
>
>
> pws
>
next prev parent reply other threads:[~2018-04-19 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180419105813epcas5p4a20cf461f81c58b8a89ad6350c8c9942@epcas5p4.samsung.com>
2018-04-19 10:57 ` Vin Shelton
2018-04-19 11:33 ` Peter Stephenson
2018-04-19 13:51 ` Vin Shelton [this message]
2018-04-19 14:06 ` Peter Stephenson
2018-04-19 14:33 ` Bart Schaefer
2018-04-19 15:29 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACeGjnVjAjJVi1uWDGhn_5VLJRUEu80idjNOhspCfsE8EoJgkw@mail.gmail.com \
--to=acs@alumni.princeton.edu \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).