From: Vin Shelton <acs@alumni.princeton.edu>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: PATCH: autoload with explicit path
Date: Thu, 12 Jan 2017 11:05:56 -0500 [thread overview]
Message-ID: <CACeGjnW=cCzfrX-kPuorUBG3EJeXKZjpo89aSJCLX2-LL-G-VQ@mail.gmail.com> (raw)
In-Reply-To: <20170112125602.4fa64dc6@pwslap01u.europe.root.pri>
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
On Thu, Jan 12, 2017 at 7:56 AM, Peter Stephenson <p.stephenson@samsung.com>
wrote:
> I can't reproduce this using the normal tests, but I have found a
> possible cause and added a test that does fail in the same way. This
> patch fixes that failure.
>
> The problem is the overloading of filename in struct shfunc. If the
> function was alrady loaded, which is the case if it contains an
> explicit autoload -X (rather than one generated internally by looking
> at the flags for an undefined function), then the filename indicates the
> location of the source for the function. If this came from a file with
> an absolute path, and there was no explicit directory path in the
> autoload -X statement, the file path was erroneously taken as a
> directory for loading.
>
> This adds an explicit flag to indicate filename is being used for that
> purpose, unsetting it when the filename is set to the file's path.
>
> Also be a bit more careful checking if a function wasn't let loaded when
> using the new functions options. If it's already loaded they're
> irrelevant.
>
That has fixed the failures for me: I'm now seeing 48 successful tests.
Thanks,
Vin
next prev parent reply other threads:[~2017-01-13 3:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170112125605eucas1p1b2539afbacec2d28d44c6fd73b0d50af@eucas1p1.samsung.com>
2017-01-12 12:56 ` Peter Stephenson
2017-01-12 15:40 ` Daniel Shahaf
2017-01-12 15:59 ` Peter Stephenson
2017-01-12 16:09 ` Daniel Shahaf
2017-01-12 16:16 ` Peter Stephenson
2017-01-12 16:23 ` Daniel Shahaf
2017-01-12 16:34 ` Peter Stephenson
2017-01-12 16:05 ` Vin Shelton [this message]
2016-12-11 22:18 PATH: " Peter Stephenson
[not found] ` <CGME20161212160617epcas2p16960e3d95c694147035f760090e6011b@epcas2p1.samsung.com>
2016-12-12 16:05 ` Bart Schaefer
2016-12-12 16:31 ` Peter Stephenson
2017-01-10 19:31 ` Peter Stephenson
2017-01-17 18:36 ` PATCH: " Peter Stephenson
2017-01-17 22:17 ` Daniel Shahaf
2017-01-18 0:06 ` Bart Schaefer
2017-01-18 9:21 ` Peter Stephenson
2017-01-18 9:17 ` Peter Stephenson
2017-01-18 22:26 ` Bart Schaefer
2017-01-19 9:39 ` Peter Stephenson
2017-01-18 9:53 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACeGjnW=cCzfrX-kPuorUBG3EJeXKZjpo89aSJCLX2-LL-G-VQ@mail.gmail.com' \
--to=acs@alumni.princeton.edu \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).