From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: PATCH: autoload with explicit path
Date: Thu, 12 Jan 2017 16:09:21 +0000 [thread overview]
Message-ID: <20170112160921.GA8048@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20170112155920.360ad5d7@pwslap01u.europe.root.pri>
Peter Stephenson wrote on Thu, Jan 12, 2017 at 15:59:20 +0000:
> On Thu, 12 Jan 2017 15:40:57 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > We could also put these two members in a union{} if they are mutually
> > exclusive (if at least one of them is NULL at all times).
>
> They are mutually exclusive, as one is only useful for an autoload and
> one is only useful with real source, which is why it uses the same
> pointer. Making it a union doesn't actually change anything: it's still
> the same set of of reads and writes.
Of course it would be exactly the same machine code, but the source code
would be more robust against bugs. It's a lot harder to refer to the
wrong union member than to use the ->filename member without testing
PM_LOADDIR first.
next prev parent reply other threads:[~2017-01-12 16:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170112125605eucas1p1b2539afbacec2d28d44c6fd73b0d50af@eucas1p1.samsung.com>
2017-01-12 12:56 ` Peter Stephenson
2017-01-12 15:40 ` Daniel Shahaf
2017-01-12 15:59 ` Peter Stephenson
2017-01-12 16:09 ` Daniel Shahaf [this message]
2017-01-12 16:16 ` Peter Stephenson
2017-01-12 16:23 ` Daniel Shahaf
2017-01-12 16:34 ` Peter Stephenson
2017-01-12 16:05 ` Vin Shelton
2016-12-11 22:18 PATH: " Peter Stephenson
[not found] ` <CGME20161212160617epcas2p16960e3d95c694147035f760090e6011b@epcas2p1.samsung.com>
2016-12-12 16:05 ` Bart Schaefer
2016-12-12 16:31 ` Peter Stephenson
2017-01-10 19:31 ` Peter Stephenson
2017-01-17 18:36 ` PATCH: " Peter Stephenson
2017-01-17 22:17 ` Daniel Shahaf
2017-01-18 0:06 ` Bart Schaefer
2017-01-18 9:21 ` Peter Stephenson
2017-01-18 9:17 ` Peter Stephenson
2017-01-18 22:26 ` Bart Schaefer
2017-01-19 9:39 ` Peter Stephenson
2017-01-18 9:53 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112160921.GA8048@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).