From: Philippe Altherr <philippe.altherr@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: "Zsh hackers list" <zsh-workers@zsh.org>,
"Lawrence Velázquez" <larryv@zsh.org>
Subject: Re: [Patch] Fix ERR_RETURN behavior in and/or statements
Date: Sat, 3 Dec 2022 02:36:30 +0100 [thread overview]
Message-ID: <CAGdYchvG0tTLVzL09pTHpQH8ZrFwbu2z8Q_TnPjA0oYYQG39zg@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchsqNTSDY=y32NLsHr5WP34a+nRG=UF1R0eun7bfdk+uWQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]
Fyi: my 2 messages about my 7th patch
(patch-07-remove-noerrexit-until-exec.txt) are currently stuck in the
moderation queue. No clue why.
Philippe
On Sat, Dec 3, 2022 at 2:31 AM Philippe Altherr <philippe.altherr@gmail.com>
wrote:
> Hi Bart,
>
> With my last patch (patch-08-use-or-assignments-to-set-noerrexit-bits), I
> think that I'm done with code changes. The best way to understand all of my
> changes might be to first apply all my 8 patches and have a look at all the
> places that deal with noerrexit (just grep for noerrexit in all files). The
> noerrexit logic is now quite a bit smaller and also more regular. For
> example all places that deal with conditions (if condition, while
> condition, left of &&/||, and right of !) now behave in very similar ways.
> Same for all compound commands. You can then have a look at the individual
> patches.
>
> Philippe
>
>
> On Sat, Nov 26, 2022 at 4:47 AM Philippe Altherr <
> philippe.altherr@gmail.com> wrote:
>
>> I'll take a look at all of this in a couple of days.
>>>
>>
>> Sounds good
>>
>> I just sent a 6th patch. With that, all the errexit issues I'm aware of
>> are fixed.
>>
>> I still have on my todo list to write a NEWS item that documents the
>> changes/fixes. So there will be a 7th patch but that one will only touch
>> the NEWS file.
>>
>> There is one last thing that I don't understand in the errexit code,
>> namely the NOERREXIT_UNTIL_EXEC bit used in execif. I will spend some time
>> studying it in the next few days. Hopefully, I don't discover new issues :-)
>>
>> Philippe
>>
>>
[-- Attachment #2: Type: text/html, Size: 2526 bytes --]
next prev parent reply other threads:[~2022-12-03 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 17:44 Philippe Altherr
2022-11-25 17:55 ` Bart Schaefer
2022-11-26 3:47 ` Philippe Altherr
2022-12-03 1:31 ` Philippe Altherr
2022-12-03 1:36 ` Philippe Altherr [this message]
2022-12-03 5:11 ` Lawrence Velázquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdYchvG0tTLVzL09pTHpQH8ZrFwbu2z8Q_TnPjA0oYYQG39zg@mail.gmail.com \
--to=philippe.altherr@gmail.com \
--cc=larryv@zsh.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).