From: Bart Schaefer <schaefer@brasslantern.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH] zsystem flock: zclose descriptor after unsuccessful lock
Date: Sat, 30 Dec 2017 09:44:28 -0800 [thread overview]
Message-ID: <CAH+w=7Y0ATw8DY3_yHtRqXXSrTAruFJi_uV=dKtrGOXCViCYHQ@mail.gmail.com> (raw)
In-Reply-To: <etPan.5a47b193.2c35fec7.13d7@zdharma.org>
On Sat, Dec 30, 2017 at 7:32 AM, Sebastian Gniazdowski
<psprint@zdharma.org> wrote:
> The patch adds preceding zclose(flock_fd) to all return 1 and return 2 code paths.
Nothing wrong with the patch but the original code structure looks
funny. Why do we return without calling zwarnnam() when errflag? I
suppose the assumption is that it only gets set if we already output
some other error message?
next prev parent reply other threads:[~2017-12-30 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 15:32 Sebastian Gniazdowski
2017-12-30 17:44 ` Bart Schaefer [this message]
2017-12-30 18:26 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7Y0ATw8DY3_yHtRqXXSrTAruFJi_uV=dKtrGOXCViCYHQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).