zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Let _approximate work w/ possible compadd function
Date: Sat, 27 May 2023 09:11:08 -0700	[thread overview]
Message-ID: <CAH+w=7Ybqejw7PzLwPB1+uPfa09gvVoY-qO_RQtHBEuKLd2q7Q@mail.gmail.com> (raw)
In-Reply-To: <20230527131253.33840-1-marlon.richert@gmail.com>

On Sat, May 27, 2023 at 6:13 AM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> Before this patch, if compadd had been overridden by a function of the
> same name, _approximate would not do corrections.

This is what _shadow was added for.  I don't remember why I didn't
apply it to _approximate when I did so for _complete_help, but
possibly it's because those usages actually conflict, i.e., when
running the help function you don't want approximate to bypass the
override?  Will have to think about this a bit when I have more time.

The primary difference from your patch is that _shadow will handle
recursive calls to the function in which it is used.


  reply	other threads:[~2023-05-27 16:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27 13:12 Marlon Richert
2023-05-27 16:11 ` Bart Schaefer [this message]
2023-06-15 14:29   ` Marlon Richert
2023-06-21  3:28     ` Bart Schaefer
2023-07-04  7:06       ` Marlon Richert
2023-06-21  3:49     ` Bart Schaefer
2023-05-27 17:47 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7Ybqejw7PzLwPB1+uPfa09gvVoY-qO_RQtHBEuKLd2q7Q@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).