Re: Test release: zsh 5.5.1-test-2

Re: Test release: zsh 5.5.1-test-2

[Bart Schaefer]

I have a new build error on a system that does not have yodl.  I
recall seeing an email about a change to build tree management for
when the docs are built out of tree, but I can't find it in the git
history.

cd .. && \
      /bin/sh ./config.status `echo Doc/Makefile | sed 's%^./%%'`
config.status: creating Doc/Makefile
( \
      echo 'IFDEF(INCWSLEVEL)(INCWSLEVEL())(STARTDEF())'; \
      echo 'def(version)(0)('5.5.1-test-2')'; \
      echo 'def(date)(0)(''August 26, 2018'')'; \
      echo 'def(zshenv)(0)(/etc/zshenv)'; \
      echo 'def(zprofile)(0)(/etc/zprofile)'; \
      echo 'def(zshrc)(0)(/etc/zshrc)'; \
      echo 'def(zlogin)(0)(/etc/zlogin)'; \
      echo 'def(zlogout)(0)(/etc/zlogout)'; \
      echo 'IFDEF(DECWSLEVEL)(DECWSLEVEL())(ENDDEF())#' | tr '#' '\\'; \
    ) > ./version.yo
perl ../Util/helpfiles \
        ./zshbuiltins.1 ./help ./help.txt \
        || rm -f ./help.txt ./help/*
helpfiles: attempting man ./zshbuiltins.1 >./help/man.tmp
fgets: Undefined error: 0
Error reading man page /Users/schaefer/Public/zsh/Doc/./zshbuiltins.1
No manual entry for ./zshbuiltins.1
helpfiles: attempting nroff -man ./zshbuiltins.1 >./help/man.tmp
helpfiles: attempting col -bx <./help/man.tmp >./help/col.tmp
helpfiles: not all files were properly generated
touch ./help.txt
case ': yodl ' in :*) touch zsh.texi ;; *) \
        : yodl  -o zsh.texi -I. -w ztexi.yo version.yo zsh.yo; \
        test -f zsh.texi \
    ;; esac

Re: Test release: zsh 5.5.1-test-2

[Daniel Shahaf]

Bart Schaefer wrote on Mon, 27 Aug 2018 09:03 -0700:
> I have a new build error on a system that does not have yodl.  I
> recall seeing an email about a change to build tree management for
> when the docs are built out of tree, but I can't find it in the git
> history.
> 

You mean 43333?  I haven't pushed it yet: I didn't want to destabilize
the build system between the test release and the final release.  The
only changes I pushed were bumping the version number and fixing a
syntax error in FAQ.yo.

Try a clean rebuild, or a bisect?

Re: Test release: zsh 5.5.1-test-2

[Bart Schaefer]

On Mon, Aug 27, 2018 at 9:34 AM, Daniel Shahaf <danielsh@apache.org> wrote:
> Bart Schaefer wrote on Mon, 27 Aug 2018 09:03 -0700:
>> I have a new build error on a system that does not have yodl.  I
>> recall seeing an email about a change to build tree management for
>> when the docs are built out of tree, but I can't find it in the git
>> history.
>>
>
> You mean 43333?  I haven't pushed it yet: I didn't want to destabilize

Hmm, OK.  Could be that this isn't a new error and it's just been a
long while since Doc/Makefile was itself rebuilt.

A different oddity:

% compaudit
There are insecure directories:
/Users/schaefer/Public/zsh/Functions/Math
/Users/schaefer/Public/zsh/Completion/BSD/Type

Those two directories have become group-writable, which they were not
before.  Not critical except for running compinit out of the source
tree, but why did that mode change happen?

Re: Test release: zsh 5.5.1-test-2

[Daniel Shahaf]

Bart Schaefer wrote on Mon, 27 Aug 2018 09:59 -0700:
> On Mon, Aug 27, 2018 at 9:34 AM, Daniel Shahaf <danielsh@apache.org> wrote:
> > Bart Schaefer wrote on Mon, 27 Aug 2018 09:03 -0700:
> >> I have a new build error on a system that does not have yodl.  I
> >> recall seeing an email about a change to build tree management for
> >> when the docs are built out of tree, but I can't find it in the git
> >> history.
> >>
> >
> > You mean 43333?  I haven't pushed it yet: I didn't want to destabilize
> 
> Hmm, OK.  Could be that this isn't a new error and it's just been a
> long while since Doc/Makefile was itself rebuilt.
> 
> A different oddity:
> 
> % compaudit
> There are insecure directories:
> /Users/schaefer/Public/zsh/Functions/Math
> /Users/schaefer/Public/zsh/Completion/BSD/Type
> 
> Those two directories have become group-writable, which they were not
> before.  Not critical except for running compinit out of the source
> tree, but why did that mode change happen?

Those directories were created in 2015 and 2016.  No other directories
were created since then.  I guess that you `git checkout`ed a pre-2015
commit (perhaps an old tag?) and then did `git checkout master` with
umask 002 in effect.

Re: Test release: zsh 5.5.1-test-2

[Bart Schaefer]

On Mon, Aug 27, 2018 at 10:51 AM, Daniel Shahaf <danielsh@apache.org> wrote:
> Bart Schaefer wrote on Mon, 27 Aug 2018 09:59 -0700:
>> % compaudit
>> There are insecure directories:
>> /Users/schaefer/Public/zsh/Functions/Math
>> /Users/schaefer/Public/zsh/Completion/BSD/Type
>
> Those directories were created in 2015 and 2016.  No other directories
> were created since then.  I guess that you `git checkout`ed a pre-2015
> commit (perhaps an old tag?) and then did `git checkout master` with
> umask 002 in effect.

I have done literally nothing in that git tree in months except "git
pull", "git whatchanged", and "make".

Weird.