Re: Crash when completion script call itself.

[Bart Schaefer <schaefer@brasslantern.com>]

On Fri, Sep 29, 2017 at 7:16 AM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> This is the proposed change.  I think the compromise of reducing the
> value but making it more easily configurable is probably a good one.  It
> currently makes the new variable appear in all emulations, but I can
> change that.

Philosophically speaking, the value of 1000 for max depth was also
based on user experience, and one might expect that most environments
now have more stack space available than they did many years ago when
1000 was chosen.  So reducing this value might make it more likely
that people will encounter the "depth exceeded" error.  At the least
the error message should be updated to mention increasing FUNCNEST ?

With respect to the #ifdefs, I think entirely removing FUNCNEST is a
bad idea -- it should remain so that its value can be examined.  We
could go so far as to mark it readonly if preventing it from being
reset is the intention.  I guess that affects whether the shell keeps
track of the current depth, too, but that doesn't seem like much
overhead.