zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: "Lawrence Velázquez" <larryv@zsh.org>,
	"Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: Does add-zle-hook-widget violate the contract of ZLE hook widgets?
Date: Sat, 26 Jun 2021 10:51:56 -0400	[thread overview]
Message-ID: <CAH+w=7ZS+c-R0AkrGGh8Jtak2WcCQYRgHPFuvttF1A2CjMb=JQ@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDtiGMCaCSNsp8WX0Z+E8f7M5GXZgkCf-4pSDYnXBfdXkg@mail.gmail.com>

On Sat, Jun 26, 2021 at 6:14 AM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> I included those changes intentionally:
> 1. In the section ZLE > Hook Widgets of the HTML version of the
> manual, I want to include a link to User Contrib > Manipulating Hook
> Functions.

Typically the way to do this would be to include a link to User
Contrib within text that says something like 'see Manipulating Hook
Functions in noderef(...)'.

> 2. To create a link, I need to use a `noderef`.
> 3. To be able to use `noderef`, I need a `texinode` to link to.
> 4. Manipulating Hook Functions doesn't have a `texinode`, so I need to add one.

You don't NEED to, you just happen to want to.  Which is not a bad
thing, but no consensus was reached about the best way to do so.

> 5. When I add a `texinode`, `make install.info` fails to compile if
> there isn't a `menu` in the same page that links to it.

That's not really what's going on.  There doesn't have to be a menu,
but a texinode can't stand by itself, it has to be linked into the
hierarchy of nodes in the document, which means that not only does it
need to reference other nodes, but other nodes need to be updated to
reference it.

> 6. Hence, I need to update the menu structure of User Contrib.

Per our previous discussion ... you chose to restructure things to
have a menu.  I had only pointed out that the new section you at first
created didn't have introductory text after the manner of similar
sections elsewhere.  Nobody weighed in on preference for either one.
There are less radical changes that could be made than restructuring,
and if restructuring is the right thing, it could be done in a
separate patch.


  reply	other threads:[~2021-06-26 14:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 20:30 Marlon Richert
2021-06-23 21:57 ` Daniel Shahaf
2021-06-23 23:33   ` Lawrence Velázquez
2021-06-24  0:09     ` Daniel Shahaf
2021-06-24 10:34   ` Marlon Richert
2021-06-24 10:45     ` Roman Perepelitsa
2021-06-24 18:54       ` Daniel Shahaf
2021-06-24 19:51         ` Roman Perepelitsa
2021-06-24 18:30     ` Daniel Shahaf
2021-06-24 21:48       ` Marlon Richert
2021-06-24 22:29         ` Lawrence Velázquez
2021-06-26 10:12           ` Marlon Richert
2021-06-26 14:51             ` Bart Schaefer [this message]
2021-06-24 23:52         ` Daniel Shahaf
2021-06-26 10:49           ` Marlon Richert
2021-06-25 17:34         ` Bart Schaefer
2021-06-27  8:19 Marlon Richert
2021-06-29  2:06 ` Bart Schaefer
2021-06-29 14:50   ` Marlon Richert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZS+c-R0AkrGGh8Jtak2WcCQYRgHPFuvttF1A2CjMb=JQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=larryv@zsh.org \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).